Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flutter beta channel removed constructor param Stack.overflow #67

Open
mockturtl opened this issue Apr 21, 2022 · 2 comments · Fixed by romitkarmakar/fancy_bottom_navigation#3 · May be fixed by #68
Open

Flutter beta channel removed constructor param Stack.overflow #67

mockturtl opened this issue Apr 21, 2022 · 2 comments · Fixed by romitkarmakar/fancy_bottom_navigation#3 · May be fixed by #68

Comments

@mockturtl
Copy link

mockturtl commented Apr 21, 2022 •
edited

This package is broken in Flutter's beta channel. Apps using it will not compile.

See flutter/flutter#98583.

Offending line is here:
https://github.com/tunitowen/fancy_bottom_navigation/blob/master/lib/fancy_bottom_navigation.dart#L111

PR incoming.
mockturtl added a commit to mockturtl/fancy_bottom_navigation that referenced this issue Apr 21, 2022
@mockturtl
fix: Stack constructor for Flutter > 2.10
bd29490 
Closes tunitowen#67.

- Replaces `overflow: Overflow.visible` with `clipBehavior: Clip.none`,
  per [migration guide](https://docs.flutter.dev/release/breaking-changes/clip-behavior#migration-guide)
- Bumps `mockito` version for compatibility with `flutter_test`.
- Renames test file to follow `*_test.dart` convention.
- Removes and gitignores `pubspec.lock`, since this is a library package.
@mockturtl mockturtl linked a pull request Apr 21, 2022 that will close this issue
Open
@James-A-White
Copy link

Apparently this is still not fixed for Flutter 3.0. A deal breaker for me at the moment. Any idea when the PR will be merged?

@techcafe13
Copy link

Dont worry, its easy to fix, until they upload the fixed version, go to the Package and most probably around line 109 there will be a Stack Widget where overflow is not accepted anymore . kindly change it as below
overflow: Overflow.visible, should be changed to clipBehavior: Clip.none,, then everything will work just as like before.

@romitkarmakar romitkarmakar mentioned this issue Jun 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mockturtl @James-A-White