Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSLint -> ESLint - Indent indent/tabs rule broken #462

Open
BurtHarris opened this issue Apr 18, 2020 · 0 comments · May be fixed by #454
Open

TSLint -> ESLint - Indent indent/tabs rule broken #462

BurtHarris opened this issue Apr 18, 2020 · 0 comments · May be fixed by #454

Comments

@BurtHarris
Copy link
Collaborator

TSLint has been deprecated in favor of ESLint. See https://eslint.org/blog/2019/01/future-typescript-eslint#top. There seems to be a good migration path, e.g. https://code.visualstudio.com/api/advanced-topics/tslint-eslint-migration.

In trying this on the antlr4ts code base, I ran into a known problem: typescript-eslint/typescript-eslint#1824! Itsounds the indent rule for typescript is broken and hard to fix.

My proposal will be to disable the indent rule in ESLint, and use a dedicated code formatter, Prettier, to address standardizing indentation etc.

@sharwell is there a good reason we've got tab-based indents?

See palantir/tslint#4534 for further info on TSLint, it seems they are no longer even accepting PRs.

@BurtHarris BurtHarris self-assigned this Apr 18, 2020
@BurtHarris BurtHarris linked a pull request Apr 26, 2020 that will close this issue
@BurtHarris BurtHarris linked a pull request Apr 26, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

1 participant