Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow selecting contacts in import dialog #6876

Closed
10 of 16 tasks
bedhub opened this issue Apr 23, 2024 · 1 comment · Fixed by #6941
Closed
10 of 16 tasks

Allow selecting contacts in import dialog #6876

bedhub opened this issue Apr 23, 2024 · 1 comment · Fixed by #6941
Labels
feature: phone book goal: mobile integration state:done meets our definition of done state:tested-with-comments Issue has been tested but some issues were found and needs review.
Milestone

Comments

@bedhub
Copy link
Contributor

bedhub commented Apr 23, 2024

As an user, I want to be able to select which contacts will be imported on the final dialog inside contacts import and vCard import

AC

  • There's a checkbox on the Import Contact Dialog to select or unselect a contact from being imported
  • All contacts are selected by default

Test Notes

  • On web and desktop:
    • All contacts start selected
    • Importing a single vcard file from the file picker works:
      • with all contacts selected
      • with some contacts selected
      • with no contacts shows an error and prevents the user from proceeding
    • Importing multiple vcard files from the file picker works:
      • with all contacts selected
      • with some contacts selected
      • with no contacts shows an error and prevents the user from proceeding
  • On mobile:
    • All contacts start selected
    • Importing the contacts from the device works:
      • with all contacts selected
      • with some contacts selected
      • with no contacts shows an error and prevents the user from proceeding
@murilopereirame
Copy link
Contributor

murilopereirame commented May 27, 2024

There's no checkbox when the layout is Single Column

Screenshot_20240527-112445

@murilopereirame murilopereirame added the state:tested-with-comments Issue has been tested but some issues were found and needs review. label May 27, 2024
@murilopereirame murilopereirame removed their assignment May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: phone book goal: mobile integration state:done meets our definition of done state:tested-with-comments Issue has been tested but some issues were found and needs review.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants