Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting credentials asks for contact permission #6813

Closed
4 tasks done
charlag opened this issue Apr 2, 2024 · 1 comment · Fixed by #6913
Closed
4 tasks done

Deleting credentials asks for contact permission #6813

charlag opened this issue Apr 2, 2024 · 1 comment · Fixed by #6913
Labels
android issues that concern the android client but not all clients bug broken functionality, usability problems, unexpected errors ios issues that concern the ios client but not all clients state:done meets our definition of done state:tested We tested it and are about to release it
Milestone
230.240528.0

Comments

@charlag
Copy link
Contributor

charlag commented Apr 2, 2024 •
edited by wrdhub

v220.240327.1

Apparently it tries to cleanup after contact sync but it was not enabled in the first place.

Test Notes

  • Contact sync still working
  • Without contact permission granted:
    • Deleting an account without contact sync enabled for the account doesn't ask for contact permission
    • Deleting an account with contact sync enabled ask for contact permission
  • With contact permission granted:
    • Deleting any account doesn't ask for contact permission
@charlag charlag added bug broken functionality, usability problems, unexpected errors android issues that concern the android client but not all clients ios issues that concern the ios client but not all clients labels Apr 2, 2024
@wrdhub
Copy link
Contributor

wrdhub commented Apr 3, 2024

#6805 also is asking for contact permission at an odd time, so I want to connect them.

@murilopereirame murilopereirame self-assigned this May 3, 2024
@murilopereirame murilopereirame mentioned this issue May 3, 2024
Merged
@charlag charlag added the state:done meets our definition of done label May 7, 2024
@kib42 kib42 added this to the Notifications milestone May 21, 2024
@wrdhub wrdhub assigned wrdhub and unassigned murilopereirame and wrdhub May 22, 2024
@wrdhub wrdhub added the state:tested We tested it and are about to release it label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
android issues that concern the android client but not all clients bug broken functionality, usability problems, unexpected errors ios issues that concern the ios client but not all clients state:done meets our definition of done state:tested We tested it and are about to release it
Projects
None yet
Milestone
230.240528.0
Development

Successfully merging a pull request may close this issue.

Fix app asking for contact permission when removing account tutao/tutanota
4 participants
@charlag @murilopereirame @kib42 @wrdhub