Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview in email notification: sender & recipient #6608

Closed
36 of 42 tasks
Tracked by #6579
charlag opened this issue Feb 26, 2024 · 2 comments · Fixed by #6927
Closed
36 of 42 tasks
Tracked by #6579

Preview in email notification: sender & recipient #6608

charlag opened this issue Feb 26, 2024 · 2 comments · Fixed by #6927
Labels
android issues that concern the android client but not all clients feature: notification goal: mobile integration ios issues that concern the ios client but not all clients state:done meets our definition of done state:tested-with-comments Issue has been tested but some issues were found and needs review.
Milestone
230.240528.0

Comments

@charlag
Copy link
Contributor

charlag commented Feb 26, 2024 •
edited by wrdhub

Small version of preview: only sender and recipient

  • Make changes to notification data to point to correct email
  • Download Mail entity and display it as a notification
  • Implement credential storage in native:
    • iOS
    • Android
    • Desktop
  • Migrate credentials to native storage
  • Implement a preferences section for background notifications
  • Change credential encryption
    • Desktop
    • iOS
    • Android
  • Rebase
  • Cleanup iOS after code reorganization
  • Server changes for iOS
  • Documentation

Test notes

Everything needs to be tested on all three platforms:

  • Desktop
  • Android
  • iOS
  • Test server with tuadb!614
  • Extended notification options
    • A new section notification with notification content and Push Identifier
    • For new logins, set to ONLY_SENDER
    • For existing logins, NO_SENDER_OR_SUBJECT
  • Extended notification
    • When set to NO_SENDER_OR_SUBJECT, notification title is New email received and body is recipient address
    • For other options, notification title is sender's address and body is recipient address
  • App lock method
    • On desktop, has two options Automatic unlock and App password
    • On mobile, has three options Automatic unlock, System password or biometrics and Biometrics
  • App lock
    • On desktop, app password works as before
    • On mobile, if set to System password or biometrics or Biometrics, password or biometrics needs to be verified before login and unlock
  • Migration
    • Credentials still work after updating from an old version
  • Desktop notifications (regression). Use terminal output as help.
    • It reconnects after connection was broken
    • It tries to reconnect with increased time interval when it fails
    • It connects after logging in with a new account
    • It stops reconnecting when there are no valid logins to connect with
  • Alarms still are received and are scheduled/unscheduled
  • Sharing on iOS still works
@charlag charlag added goal: mobile integration feature: notification new feature user stories in varying refinement states android issues that concern the android client but not all clients ios issues that concern the ios client but not all clients labels Feb 26, 2024
@charlag charlag mentioned this issue Feb 26, 2024
Open
3 tasks
@bedhub bedhub removed the new feature user stories in varying refinement states label Feb 27, 2024
charlag added a commit that referenced this issue May 10, 2024
@charlag @wec43
Extended notification preview, change credential encryption
9e1e1e3 
Implemented extended notifications which include the sender.

Re-implemented credential encryption and storage, moved credential
data to the native storage, changed credential encryption on mobile to
always be device lock + implement app lock independently of encryption.

Re-implemented SSE on desktop in a more modular way.

Re-organized iOS app to share the code between the main app code and
app extensions.

Close #6608

Co-authored-by: wec43 <wec@tutao.de>
charlag added a commit that referenced this issue May 10, 2024
@charlag @wec43
Extended notification preview, change credential encryption
5ab365a 
Implemented extended notifications which include the sender.

Re-implemented credential encryption and storage, moved credential
data to the native storage, changed credential encryption on mobile to
always be device lock + implement app lock independently of encryption.

Re-implemented SSE on desktop in a more modular way.

Re-organized iOS app to share the code between the main app code and
app extensions.

Close #6608

Co-authored-by: wec43 <wec@tutao.de>
@charlag charlag mentioned this issue May 10, 2024
Merged
25 tasks
charlag added a commit that referenced this issue May 10, 2024
@charlag @wec43
Extended notification preview, change credential encryption
7e1bdcf 
Implemented extended notifications which include the sender.

Re-implemented credential encryption and storage, moved credential
data to the native storage, changed credential encryption on mobile to
always be device lock + implement app lock independently of encryption.

Re-implemented SSE on desktop in a more modular way.

Re-organized iOS app to share the code between the main app code and
app extensions.

Close #6608

Co-authored-by: wec43 <wec@tutao.de>
@wrdhub wrdhub added the state:done meets our definition of done label May 17, 2024
@wrdhub wrdhub added this to the Notifications milestone May 22, 2024
@wrdhub wrdhub unassigned charlag and wec43 May 22, 2024
wec43 added a commit that referenced this issue May 22, 2024
@charlag @wec43
Extended notification preview, change credential encryption
6ba644a 
Implemented extended notifications which include the sender.

Re-implemented credential encryption and storage, moved credential
data to the native storage, changed credential encryption on mobile to
always be device lock + implement app lock independently of encryption.

Re-implemented SSE on desktop in a more modular way.

Re-organized iOS app to share the code between the main app code and
app extensions.

Close #6608

Co-authored-by: wec43 <wec@tutao.de>
github-merge-queue bot pushed a commit that referenced this issue May 22, 2024
@charlag @wec43 @wrdhub
Extended notification preview, change credential encryption
ad83f75 
Implemented extended notifications which include the sender.

Re-implemented credential encryption and storage, moved credential
data to the native storage, changed credential encryption on mobile to
always be device lock + implement app lock independently of encryption.

Re-implemented SSE on desktop in a more modular way.

Re-organized iOS app to share the code between the main app code and
app extensions.

Close #6608

Co-authored-by: wec43 <wec@tutao.de>
@wrdhub wrdhub self-assigned this May 24, 2024
@paw-hub paw-hub self-assigned this May 27, 2024
@paw-hub
Copy link
Contributor

paw-hub commented May 27, 2024 •
edited

Desktop notifications do not show sender if app password is enabled.

I asked and this is apparently intentional, however it is not immediately obvious that this should be the case (no feedback is shown to the user that these features cannot be used together).

@wrdhub wrdhub mentioned this issue May 28, 2024
Closed
@wrdhub
Copy link
Contributor

wrdhub commented May 28, 2024

Issue with iOS: #7014

@wrdhub wrdhub added the state:tested-with-comments Issue has been tested but some issues were found and needs review. label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
android issues that concern the android client but not all clients feature: notification goal: mobile integration ios issues that concern the ios client but not all clients state:done meets our definition of done state:tested-with-comments Issue has been tested but some issues were found and needs review.
Projects
None yet
Milestone
230.240528.0
Development

Successfully merging a pull request may close this issue.

Extended notification preview tutao/tutanota
5 participants
@charlag @bedhub @paw-hub @wrdhub @wec43