Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for osx-arm64 runtimes #18

Open
tvandinther opened this issue Feb 19, 2024 · 0 comments
Open

Add support for osx-arm64 runtimes #18

tvandinther opened this issue Feb 19, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@tvandinther
Copy link
Owner

First raised in #17, the FFI binaries are only built for x64 on Linux, Windows and MacOS. MacOS running on Apple silicon is common enough to require support.

Expected changes:

A new build step targetting a Github Actions runner using Apple silicon to build an additional FFI binary.

Github has recently released into beta their macos-14 runner which uses the M1 chip. A new build step can be created targetting this runner.
https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

Copying the new osx-arm64 binary into the package

The csproj file will need to be changed to distinguish between and copy the x64 and arm64 binaries into their respective runtime directories. According to the MSBuild docs this should be runtimes/osx-arm64/native

@tvandinther tvandinther added enhancement New feature or request good first issue Good for newcomers labels Feb 19, 2024
@tvandinther tvandinther added this to the Version 1.0 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant