Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly normalize subtraction followed by a variable #430

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: properly normalize subtraction followed by a variable #430

wants to merge 1 commit into from

Conversation

sibbng
Copy link
Contributor

@sibbng sibbng commented Dec 30, 2022

Fixes #429

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and verify the project with pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until Twind 1.0

@sibbng sibbng requested a review from sastan as a code owner December 30, 2022 15:04
@codesandbox
Copy link

codesandbox bot commented Dec 30, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@stackblitz
Copy link

stackblitz bot commented Dec 30, 2022

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Dec 30, 2022

🦋 Changeset detected

Latest commit: ac3b5d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages
Name Type
@twind/core Patch
@twind/preset-tailwind Patch
@example/basic Patch
@example/playground Patch
@example/using-tailwind-forms Patch
@example/with-gatsby Patch
@example/with-lit Patch
@example/with-remix Patch
@example/with-remix_react-v18 Patch
@example/with-web-components Patch
@twind/cdn Patch
@twind/intellisense Patch
@twind/preset-autoprefix Patch
@twind/preset-container-queries Patch
@twind/preset-ext Patch
@twind/preset-line-clamp Patch
@twind/preset-radix-ui Patch
@twind/preset-tailwind-forms Patch
@twind/preset-typography Patch
twind Patch
gatsby-plugin-twind Patch
@twind/with-next Patch
@twind/with-react Patch
@twind/with-remix Patch
@twind/with-sveltekit Patch
@twind/with-web-components Patch
@sites/twind.style Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Dec 30, 2022 •
edited

Pull Request Test Coverage Report for Build 3807553581

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 92.811%
Totals Coverage Status
Change from base Build 3790257809: 0.004%
Covered Lines: 10519
Relevant Lines: 11336
💛 - Coveralls

@sastan
Copy link
Collaborator

sastan commented Jan 6, 2023

Great. Thank you very much for taking the time. I will try, test and review soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sastan sastan Awaiting requested review from sastan sastan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: subtraction followed by a variable not normalized properly
3 participants
@sibbng @coveralls @sastan