diff --git a/js/src/tab.js b/js/src/tab.js index e9a6f555fe61..bcbb5c5ea258 100644 --- a/js/src/tab.js +++ b/js/src/tab.js @@ -187,7 +187,12 @@ class Tab { element.classList.add(CLASS_NAME_SHOW) } - if (element.parentNode && $(element.parentNode).hasClass(CLASS_NAME_DROPDOWN_MENU)) { + let parent = element.parentNode + if (parent && parent.nodeName === 'LI') { + parent = parent.parentNode + } + + if (parent && $(parent).hasClass(CLASS_NAME_DROPDOWN_MENU)) { const dropdownElement = $(element).closest(SELECTOR_DROPDOWN)[0] if (dropdownElement) { diff --git a/js/tests/unit/tab.js b/js/tests/unit/tab.js index a0c4ddf15547..9c9b286f04b9 100644 --- a/js/tests/unit/tab.js +++ b/js/tests/unit/tab.js @@ -345,6 +345,28 @@ $(function () { assert.notOk($tabs.find('li:last-child .dropdown-menu a:first-child').hasClass('active')) }) + QUnit.test('should support li > .dropdown-item', function (assert) { + assert.expect(2) + var tabsHTML = [ + '' + ].join('') + var $tabs = $(tabsHTML).appendTo('#qunit-fixture') + + $tabs.find('.dropdown-item').trigger('click') + assert.ok($tabs.find('.dropdown-item').hasClass('active')) + assert.notOk($tabs.find('.nav-link:not(.dropdown-toggle)').hasClass('active')) + }) + QUnit.test('Nested tabs', function (assert) { assert.expect(2) var done = assert.async()