Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dart Sass & Ruby Sass compatibility #29755

Merged
merged 1 commit into from Nov 28, 2019

Conversation

MartijnCuppens
Copy link
Member

@MartijnCuppens MartijnCuppens requested a review from a team as a code owner November 27, 2019 15:59
@MartijnCuppens MartijnCuppens added this to Inbox in v5 via automation Nov 27, 2019
Copy link
Member

@ysds ysds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MartijnCuppens LGTM.

The #{$value1 "+" $value2} and #{$value1 "-" $value2} is another solution, but either is fine.

v5 automation moved this from Inbox to Approved Nov 27, 2019
@MartijnCuppens
Copy link
Member Author

MartijnCuppens commented Nov 27, 2019

The minus isn't causing any issues if I'm not mistaken?

Edit: I've tested this, it's not causing any issues

@MartijnCuppens MartijnCuppens changed the title Fix dart Sass compatibility Fix Dart Sass & Ruby Sass compatibility Nov 27, 2019
@ysds
Copy link
Member

ysds commented Nov 28, 2019

Yep, there is no problem with the subtract().

My point is for reduce the code complexity by using the same format to plus and minus.

@XhmikosR XhmikosR merged commit 0964a88 into master Nov 28, 2019
v5 automation moved this from Approved to Shipped Nov 28, 2019
@XhmikosR XhmikosR deleted the master-mc-fix-dart-sass-functions branch November 28, 2019 07:48
XhmikosR pushed a commit that referenced this pull request Nov 28, 2019
@XhmikosR XhmikosR added this to Done in v4.4.1 Nov 28, 2019
XhmikosR pushed a commit that referenced this pull request Nov 28, 2019
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.4.1
  
Shipped
v5
  
Shipped
Development

Successfully merging this pull request may close these issues.

4.4.0 add function compilation is wrong
3 participants