Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabled custom checkbox with gradients is not grayed out in checked state #29809

Closed
kkozlik opened this issue Dec 6, 2019 · 3 comments · Fixed by #30922
Closed

disabled custom checkbox with gradients is not grayed out in checked state #29809

kkozlik opened this issue Dec 6, 2019 · 3 comments · Fixed by #30922

Comments

@kkozlik
Copy link

kkozlik commented Dec 6, 2019

If the custom checkbox is in checked state and if gradients are enabled it has a same look whether it is enabled or disabled.

Can't reproduce a codepen example, because I can't enabled gradients without compiling the scss.

I think the solution might be adding:

background-image:none;

to scss/_custom-forms.scss line 138

Tested with:

  • bootstrap 4.4.1
  • linux
  • chromium 78.0.3904.108
@kkozlik
Copy link
Author

kkozlik commented Dec 6, 2019

And the same is for custom radio button

@ajcerejeira
Copy link

I can confirm that this is also happening to me:

<div class="custom-control custom-switch">
  <input type="checkbox" id="checkbox" class="custom-control-input" checked disabled>
  <label for="checkbox" class="custom-control-label disabled"></label>
</div>

Result:

image

Expected:

image

@ffoodd ffoodd linked a pull request May 29, 2020 that will close this issue
@ffoodd ffoodd added the has-pr label May 29, 2020
@mdo mdo added this to Inbox in v4.5.1 via automation Jun 15, 2020
@XhmikosR
Copy link
Member

XhmikosR commented Jun 15, 2020

Fixed by #30922

@XhmikosR XhmikosR removed this from Inbox in v4.5.1 Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants