Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation fix: move width after make-container() mixin #29820

Merged
merged 3 commits into from Dec 25, 2019

Conversation

MartijnCuppens
Copy link
Member

@include make-container(); generates width: 100%, which will override the custom width. We might need to have a look at making this configurable, but first this PR which can be cherry-picked to v4.

@MartijnCuppens MartijnCuppens added this to Inbox in v5 via automation Dec 8, 2019
@MartijnCuppens MartijnCuppens added this to Inbox in v4.5.0 via automation Dec 8, 2019
@XhmikosR XhmikosR requested review from mdo and ysds December 9, 2019 10:21
@XhmikosR XhmikosR requested a review from a team December 24, 2019 19:36
v5 automation moved this from Inbox to Approved Dec 24, 2019
@MartijnCuppens MartijnCuppens merged commit c6cfc23 into master Dec 25, 2019
v5 automation moved this from Approved to Shipped Dec 25, 2019
@MartijnCuppens MartijnCuppens deleted the master-mc-fix-container-width-docs branch December 25, 2019 11:28
XhmikosR added a commit that referenced this pull request Dec 26, 2019
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
@XhmikosR XhmikosR moved this from Inbox to Shipped in v4.5.0 Jan 2, 2020
XhmikosR added a commit that referenced this pull request Jan 2, 2020
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
)

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.5.0
  
Shipped
v5
  
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

2 participants