Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Microsoft Edge for MacOS to supported browsers #29956

Merged
merged 1 commit into from Feb 17, 2020
Merged

Add Microsoft Edge for MacOS to supported browsers #29956

merged 1 commit into from Feb 17, 2020

Conversation

coliff
Copy link
Contributor

@coliff coliff commented Jan 6, 2020

The new Chromium-based Edge has been available as a beta for sometime and general availability of the final version is expected to ship from Jan 15. I think it makes sense to add it as a supported browser once it's out of beta.
REF: https://blogs.windows.com/windowsexperience/2019/11/04/introducing-the-new-microsoft-edge-and-bing/

(made this change against the v4 branch so it can be updated in the docs for the v4.4.2 release though I realise this would also need to be ported to the v5 branch)

@XhmikosR
Copy link
Member

XhmikosR commented Jan 6, 2020

Everything should go into the master branch and if need to we will cherry pick in v4-dev.

Although TBH I see no value mentioning specifically the "new" Edge being it's just Chromium. We should probably just reword this part and not mention Opera specifically, either.

/CC @mdo

@mdo
Copy link
Member

mdo commented Jan 7, 2020

If we end up listing browser engines, I'd think it would still be super helpful for some folks out there to see an exact browser/version list.

@XhmikosR
Copy link
Member

XhmikosR commented Jan 8, 2020

I think we should keep it simple. The only reason we mention Edge is because it was using a different Engine. The same goes for Opera before they switched to Chromium.

We should reword this section. Edge should still be listed though, based on our .browserlistrc and the karma browsers we are using.

@mdo
Copy link
Member

mdo commented Feb 15, 2020

Understand the feedback that we can reword this section perhaps, but for the time being, we can fix one small problem here and show that it's supported on Mac :). I'll open an issue to revisit the docs more thoroughly later.

@mdo mdo added this to Inbox in v5 via automation Feb 15, 2020
@XhmikosR
Copy link
Member

This can land as long as we have an issue to track the rewording part.

@mdo
Copy link
Member

mdo commented Feb 16, 2020

This can land as long as we have an issue to track the rewording part.

Done in #30194.

@XhmikosR
Copy link
Member

Though it should have been targeting the master branch.

@XhmikosR XhmikosR changed the base branch from v4-dev to master February 16, 2020 20:00
@XhmikosR XhmikosR changed the base branch from master to v4-dev February 16, 2020 20:00
@XhmikosR XhmikosR changed the base branch from v4-dev to master February 17, 2020 07:49
The new Chromium-based Edge has been available as a beta for sometime and general availability of the final version is expected to ship from Jan 15. I think it makes sense to add it as a supported browser once it's out of beta.
REF: https://blogs.windows.com/windowsexperience/2019/11/04/introducing-the-new-microsoft-edge-and-bing/
@XhmikosR
Copy link
Member

Alright, I did this manually but please next time target the master branch first.

@XhmikosR XhmikosR moved this from Inbox to Approved in v5 Feb 17, 2020
@XhmikosR XhmikosR merged commit cc44b44 into twbs:master Feb 17, 2020
v5 automation moved this from Approved to Shipped Feb 17, 2020
@XhmikosR XhmikosR added this to Inbox in v4.5.0 via automation Feb 17, 2020
@XhmikosR XhmikosR moved this from Inbox to Cherry-picked in v4.5.0 Feb 17, 2020
XhmikosR pushed a commit that referenced this pull request Feb 17, 2020
The new Chromium-based Edge has been available as a beta for sometime and general availability of the final version is expected to ship from Jan 15. I think it makes sense to add it as a supported browser once it's out of beta.
REF: https://blogs.windows.com/windowsexperience/2019/11/04/introducing-the-new-microsoft-edge-and-bing/
@coliff coliff deleted the patch-1 branch February 17, 2020 11:56
@coliff
Copy link
Contributor Author

coliff commented Feb 17, 2020

Alright, I did this manually but please next time target the master branch first.

will do. thanks for merging. 👍

XhmikosR pushed a commit that referenced this pull request Feb 17, 2020
The new Chromium-based Edge has been available as a beta for sometime and general availability of the final version is expected to ship from Jan 15. I think it makes sense to add it as a supported browser once it's out of beta.
REF: https://blogs.windows.com/windowsexperience/2019/11/04/introducing-the-new-microsoft-edge-and-bing/
@XhmikosR XhmikosR moved this from Cherry-picked to Shipped in v4.5.0 Feb 22, 2020
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
The new Chromium-based Edge has been available as a beta for sometime and general availability of the final version is expected to ship from Jan 15. I think it makes sense to add it as a supported browser once it's out of beta.
REF: https://blogs.windows.com/windowsexperience/2019/11/04/introducing-the-new-microsoft-edge-and-bing/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.5.0
  
Shipped
v5
  
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

3 participants