Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added focus state to .btn-link #30036

Merged
merged 3 commits into from Mar 23, 2020
Merged

Added focus state to .btn-link #30036

merged 3 commits into from Mar 23, 2020

Conversation

timdujardin
Copy link
Contributor

@timdujardin timdujardin commented Jan 17, 2020

@XhmikosR
Copy link
Member

Isn't v4 affected by this? If so, we better backport this.

@MartijnCuppens MartijnCuppens added this to Inbox in v4.5.0 via automation Jan 17, 2020
@MartijnCuppens MartijnCuppens added this to Inbox in v5 via automation Jan 17, 2020
@ysds ysds added this to Inbox in v5.0.0-alpha2 via automation Feb 14, 2020
@ysds ysds removed this from Inbox in v5 Feb 14, 2020
@XhmikosR XhmikosR added this to Inbox in v5 via automation Mar 19, 2020
@XhmikosR XhmikosR removed this from Inbox in v5.0.0-alpha2 Mar 19, 2020
@XhmikosR
Copy link
Member

Moving this to v5. @patrickhlauke please have a look :) Also, @ysds @MartijnCuppens

@patrickhlauke
Copy link
Member

patrickhlauke commented Mar 19, 2020

isn't the point of .btn-link that it's a button, but will look like a link? which is does by showing the underline?

[edit: ah, but i see that we've changed the focus style for links anyway to show outline - or was it always like that and i just missed it? been a while - so yeh sure]

Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need some kind of focus indication when #30389 lands

v5 automation moved this from Inbox to Approved Mar 19, 2020
@MartijnCuppens MartijnCuppens merged commit 3e5bc4c into twbs:master Mar 23, 2020
v5 automation moved this from Approved to Shipped Mar 23, 2020
@XhmikosR XhmikosR moved this from Inbox to Cherry-picked in v4.5.0 Mar 25, 2020
XhmikosR pushed a commit that referenced this pull request Mar 25, 2020
XhmikosR pushed a commit that referenced this pull request Mar 25, 2020
XhmikosR pushed a commit that referenced this pull request Mar 28, 2020
XhmikosR pushed a commit that referenced this pull request Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.5.0
  
Shipped
v5
  
Shipped
Development

Successfully merging this pull request may close these issues.

Focus state removed from btn-link:focus ruleset
4 participants