Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headings hierarchy in theming.md #30207

Merged
merged 3 commits into from Feb 17, 2020
Merged

Headings hierarchy in theming.md #30207

merged 3 commits into from Feb 17, 2020

Conversation

ffoodd
Copy link
Member

@ffoodd ffoodd commented Feb 17, 2020

Aside from #30168, ensure "Escape SVG" and "Add and Subtract" are under "Sass" / "Functions" in the headings hierarchy.

@ffoodd ffoodd mentioned this pull request Feb 17, 2020
@ffoodd ffoodd requested a review from XhmikosR February 17, 2020 13:56
@XhmikosR XhmikosR added this to Inbox in v5 via automation Feb 17, 2020
v5 automation moved this from Inbox to Approved Feb 17, 2020
@XhmikosR
Copy link
Member

Perhaps we should backport this.

@ffoodd
Copy link
Member Author

ffoodd commented Feb 17, 2020

Perhaps we should backport this.

Indeed (at least in prod: https://getbootstrap.com/docs/4.4/getting-started/theming/#functions), I'll open another PR right away.

@XhmikosR
Copy link
Member

No need to, we can cherry pick it after this is merged.

@XhmikosR XhmikosR merged commit 48c8697 into twbs:master Feb 17, 2020
v5 automation moved this from Approved to Shipped Feb 17, 2020
@XhmikosR XhmikosR added this to Inbox in v4.5.0 via automation Feb 17, 2020
@XhmikosR XhmikosR moved this from Inbox to Cherry-picked in v4.5.0 Feb 17, 2020
@XhmikosR XhmikosR moved this from Cherry-picked to Shipped in v4.5.0 Feb 22, 2020
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.5.0
  
Shipped
v5
  
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

3 participants