Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modal docs #30325

Merged
merged 5 commits into from Mar 23, 2020
Merged

Update modal docs #30325

merged 5 commits into from Mar 23, 2020

Conversation

ysds
Copy link
Member

@ysds ysds commented Mar 2, 2020

  • Simplify modal snippets
  • Use id for data-target
  • Unify the id positions

Closes #30055

@ysds ysds added this to Inbox in v5 via automation Mar 2, 2020
@ysds ysds added this to Inbox in v4.5.0 via automation Mar 2, 2020
@ysds ysds requested review from a team and XhmikosR March 2, 2020 14:56
@ysds ysds changed the title Master ysds modal docs Update modal docs Mar 2, 2020
@ysds ysds moved this from Inbox to Review in v5 Mar 2, 2020
@MartijnCuppens
Copy link
Member

Imo, this PR removes a little too much. I think people like it to just copy-paste the whole modal.

@ysds
Copy link
Member Author

ysds commented Mar 4, 2020

I do not think so. The first snippet in the "Scrolling long content" section makes no sense. Also, the current snippets of the size options don't work (broken) already because there are no content in the .modal-content. To make all snippets that can be copied successfully need too long line.

@XhmikosR
Copy link
Member

XhmikosR commented Mar 4, 2020

I'm in between personally; I see @ysds's and @MartijnCuppens's points.

/CC @mdo to the rescue :P

@XhmikosR XhmikosR requested a review from mdo March 4, 2020 13:46
@patrickhlauke
Copy link
Member

FWIW i don't mind the cuts here

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cut it! :D

v5 automation moved this from Review to Approved Mar 20, 2020
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, let's do this

@MartijnCuppens MartijnCuppens merged commit 1b7e13f into master Mar 23, 2020
v5 automation moved this from Approved to Shipped Mar 23, 2020
@MartijnCuppens MartijnCuppens deleted the master-ysds-modal-docs branch March 23, 2020 17:15
@XhmikosR XhmikosR moved this from Inbox to Cherry-picked in v4.5.0 Mar 25, 2020
XhmikosR pushed a commit that referenced this pull request Mar 25, 2020
XhmikosR pushed a commit that referenced this pull request Mar 25, 2020
XhmikosR pushed a commit that referenced this pull request Mar 28, 2020
XhmikosR pushed a commit that referenced this pull request Mar 31, 2020
XhmikosR pushed a commit that referenced this pull request Mar 31, 2020
@XhmikosR XhmikosR moved this from Cherry-picked to Shipped in v4.5.0 Mar 31, 2020
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.5.0
  
Shipped
v5
  
Shipped
Development

Successfully merging this pull request may close these issues.

Modal Documentation for Vertically Centered isn't Correct
5 participants