Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabs - accessibility issue when using ul/li semantic #30381

Merged
merged 3 commits into from Apr 10, 2020

Conversation

Lausselloic
Copy link
Contributor

fix #30338 add aria-role presentation on li element when ul element has role tablist and remove dropdown from visual tests as they've been removed from doc

@Lausselloic Lausselloic requested a review from a team as a code owner March 11, 2020 15:38
@XhmikosR
Copy link
Member

Why does this target v4-dev specifically? Isn't the issue present in master?

@Lausselloic
Copy link
Contributor Author

I'll take a look on v5

@XhmikosR
Copy link
Member

We generally target the master branch and then backport stuff in v4-dev. Not sure if the patch will apply clean going from master to v4-dev (probably not), so it should be OK for this specific case.

Generally we target master and cherry pick or apply manually what's needed for v4-dev.

@Lausselloic
Copy link
Contributor Author

thanks for this info for other PR I will target the master

@ffoodd
Copy link
Member

ffoodd commented Mar 27, 2020

FYI related #30382 (for v5) is approved by @patrickhlauke :)

@ffoodd
Copy link
Member

ffoodd commented Mar 30, 2020

@XhmikosR It's been merged in v5, I guess it can be merged in v4 too :)

@XhmikosR
Copy link
Member

Yeah, still waiting for @patrickhlauke approval, because this isn't a cherry pick.

@XhmikosR XhmikosR merged commit 0cf29ba into twbs:v4-dev Apr 10, 2020
@XhmikosR XhmikosR moved this from Inbox to Shipped in v4.5.0 Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.5.0
  
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

4 participants