Use box-shadow mixin for form controls
#30480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zalog
changed the title
box-shadow mixinbox-shadow mixin
zalog
force-pushed
the
zalog-form-control-shadow
branch
2 times, most recently
from
c3a14c5
to
a315360
Compare
|
Does this remove the focus outline when |
Fixes css property `box-shadow` become invalid. The css property is invalid if one of `$input-box-shadow` or `$input-focus-box-shadow` is `none`. The `box-shadow` mixin verifies for `length($string) == 1`.
zalog
force-pushed
the
zalog-form-control-shadow
branch
from
a315360
to
c22c836
Compare
|
@ysds tnks for feedback! Of course you're right :) |
ysds
approved these changes
Apr 1, 2020
MartijnCuppens
changed the title
box-shadow mixinbox-shadow mixin for form controls
MartijnCuppens
added a commit
that referenced
this pull request
Apr 6, 2020
XhmikosR
pushed a commit
that referenced
this pull request
Apr 7, 2020
XhmikosR
pushed a commit
that referenced
this pull request
Apr 10, 2020
XhmikosR
pushed a commit
that referenced
this pull request
Apr 13, 2020
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes css property
box-shadowbecome invalid.That happends if one of
$input-box-shadowor$input-focus-box-shadowisnone.Our
box-shadowmixin verifies forlength($string) == 1and it covers that case.LE: Oh, this relates with #30394
cc:// @mdo @ysds