Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Growing spinners show as blank in Safari #30493

Closed
ryanditjia opened this issue Mar 31, 2020 · 18 comments · Fixed by #30504
Closed

Growing spinners show as blank in Safari #30493

ryanditjia opened this issue Mar 31, 2020 · 18 comments · Fixed by #30504

Comments

@ryanditjia
Copy link

Steps to reproduce:
Using OS / browsers listed below, insert .spinner-grow in your project, or visit Boostrap’s growing spinner doc.

macOS Catalina 10.15.4
Safari 13.1 / Safari Technology Preview 13.2

@XhmikosR
Copy link
Member

XhmikosR commented Apr 1, 2020

@MartijnCuppens can you reproduce?

@MartijnCuppens
Copy link
Member

Nope, not in Safari 13.0. Don't have a 13.1 available

@XhmikosR
Copy link
Member

XhmikosR commented Apr 1, 2020

It seems BrowserStack only has Safari 13.0.2 on Catalina, so I can't reproduce either.

@chr1stianC
Copy link

I can reproduce the issue on Safari 13.1 on Catalina 10.15.4.
The developer's console element inspector shows the spinner growing in 3 steps, but doesn't visually show it.

Btw: Safari 13.1 shows the "-webkit-animation" rule crossed out and the "animation" rule is applied. Does this apply to Safari 13.1 only?

@ysds
Copy link
Member

ysds commented Apr 1, 2020

I could reproduce... (4.3.1, v4-dev and latest)

ezgif com-optimize (1)

@XhmikosR
Copy link
Member

XhmikosR commented Apr 1, 2020

Btw: Safari 13.1 shows the "-webkit-animation" rule crossed out and the "animation" rule is applied. Does this apply to Safari 13.1 only?

That's probably because they support the unprefixed property in the new version (is my guess, at least).

That being said, I personally don't have any Apple machines to test. So, I can't tell if it's a browser issue or if there's something we could do ourselves. If it's a browser issue, someone should report it.

@MartijnCuppens
Copy link
Member

Might be caused by the missing 100% state of the spinner-grow animation. @ysds, could you check that?

Might be worth re-adding that state if it fixes the issue.

@ysds
Copy link
Member

ysds commented Apr 1, 2020

I added a 100% timing but no effects the opacity. It seems a safari issue.

@ysds
Copy link
Member

ysds commented Apr 1, 2020

Of course I toggled my reduce motion setting but no effects.

@MartijnCuppens
Copy link
Member

Of course I toggled my reduce motion setting but no effects.

First thing I tried too 😛

Weird that the spinners do work

@mdo mdo added the has-pr label Apr 2, 2020
@mdo mdo added this to Inbox in v5 via automation Apr 2, 2020
@mdo mdo added this to To do in v4.5.0 via automation Apr 2, 2020
@kaigothe
Copy link

kaigothe commented Apr 7, 2020

I have the same problem:
Safari: 13.1 (14609.1.20.111.8)
macOS: 10.14.6

@asolis
Copy link

asolis commented Apr 8, 2020

Growing spinners show as blank in Bootstrap v4.4.x, v4.3.x, and v4.2.x aren't displayed in MacOSX/Safari.

The issue is present in:
MacOSX ( High Sierra 10.13.6) with Safari (v13.1)
MacOSX ( Catalina 10.15.4) with Safari (v13.1)

*They do display correctly in both MacOSX versions using
Chrome (Version 80.0.3987.163 (Official Build) (64-bit))

While looking at the generated @keyframe spinner-grow CSS rule in Bootstrap v4.4, v4.3, and v4.2 .
They currently display the following:

@keyframes spinner-grow {
 0% {
      -webkit-transform: scale(0);
      transform: scale(0);
 }
 50% {
     opacity: 1; 
 }
}

Adding transform:scale(1) at 50% fixes the issue.

@keyframes spinner-grow {
 0% {
      -webkit-transform: scale(0);
      transform: scale(0);
 }
 50% {
     opacity: 1; 
     -webkit-transform: scale(1);
      transform: scale(1);
 }
}

The proposed changes were tested successfully under the mentioned MacOSX / Safari and Chrome version mentioned before. Below codepen reduced test case:

CodePen Reduced Test Case

@mdo
Copy link
Member

mdo commented Apr 8, 2020

No need to further tests or anything, there's been a PR open for a bit now :). See #30504.

v5 automation moved this from Inbox to Shipped Apr 8, 2020
@XhmikosR XhmikosR removed this from To do in v4.5.0 Apr 8, 2020
@kevin8479
Copy link

FYI--
IpadOS 13.4 and 13.4.1 has the problem.
IPadOS 13.3 and 13.3.1 does not have the problem.
Andrés's code pen above displays correctly tested under 13.4

@aisml
Copy link

aisml commented Oct 11, 2020

issue persists on safari Version 14.0 (15610.1.28.1.9, 15610)

@sharifyounes
Copy link

I just added the following to my CSS. It's based on @asolis suggestion above, but it doesn't "stick" at the end on Safari:

@keyframes spinner-grow {
 0% {
      -webkit-transform: scale(0);
      transform: scale(0);
 }
 40% {
     opacity: 1;
     -webkit-transform: scale(.5);
      transform: scale(.5);
 }
 80% {
     opacity: .4;
     -webkit-transform: scale(1);
      transform: scale(1);
 }
}

@DrJume
Copy link

DrJume commented Mar 28, 2022

Using a previously affected old version of bootstrap v4, this issue has been fixed by updating to iOS 15.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5
  
Shipped
Development

Successfully merging a pull request may close this issue.