Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix card list group borders & radii #30497

Merged
merged 1 commit into from Apr 2, 2020
Merged

Conversation

MartijnCuppens
Copy link
Member

@MartijnCuppens MartijnCuppens commented Apr 1, 2020

@MartijnCuppens MartijnCuppens requested a review from a team as a code owner April 1, 2020 19:50
@MartijnCuppens MartijnCuppens added this to Inbox in v5 via automation Apr 1, 2020
@MartijnCuppens MartijnCuppens added this to Inbox in v4.5.0 via automation Apr 1, 2020
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

v5 automation moved this from Inbox to Approved Apr 1, 2020
@XhmikosR XhmikosR merged commit e8e6d64 into master Apr 2, 2020
v5 automation moved this from Approved to Shipped Apr 2, 2020
@XhmikosR XhmikosR deleted the master-mc-card-list-group branch April 2, 2020 05:10
@XhmikosR XhmikosR moved this from Inbox to Needs manual backport in v4.5.0 Apr 2, 2020
MartijnCuppens added a commit that referenced this pull request Apr 6, 2020
Fix card list group borders & radii
@XhmikosR XhmikosR moved this from Needs manual backport to Cherry-picked in v4.5.0 Apr 6, 2020
XhmikosR pushed a commit that referenced this pull request Apr 7, 2020
Fix card list group borders & radii
XhmikosR pushed a commit that referenced this pull request Apr 10, 2020
Fix card list group borders & radii
XhmikosR pushed a commit that referenced this pull request Apr 13, 2020
Fix card list group borders & radii
@XhmikosR XhmikosR moved this from Cherry-picked to Shipped in v4.5.0 Apr 13, 2020
@waclaw66
Copy link

This fix brokes border between card-header and list-group, it's doubled in 4.5.
See diffierence...
https://getbootstrap.com/docs/4.4/components/card/#list-groups
https://getbootstrap.com/docs/4.5/components/card/#list-groups

mdo added a commit that referenced this pull request May 13, 2020
Consolidates some CSS and beefs up the selector to account for inherited border styles. Fixes #30793, a regression from v4.4.1 that shipped in #30497.
mdo added a commit that referenced this pull request May 14, 2020
Consolidates some CSS and beefs up the selector to account for inherited border styles. Fixes #30793, a regression from v4.4.1 that shipped in #30497.
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.5.0
  
Shipped
v5
  
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

4 participants