Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible error in documentation #30503

Closed
AliceRam opened this issue Apr 2, 2020 · 1 comment · Fixed by #30505
Closed

Possible error in documentation #30503

AliceRam opened this issue Apr 2, 2020 · 1 comment · Fixed by #30505

Comments

@AliceRam
Copy link

AliceRam commented Apr 2, 2020

Hi,

When browsing the documentation for the latest version 4.4, I came across an unused class in one of the exemples for the navbar.

The External content exemple contains the pos-f-t class which no longer exists in bootstrap:

<div class="pos-f-t">
  <div class="collapse" id="navbarToggleExternalContent">
    <div class="bg-dark p-4">
      <h5 class="text-white h4">Collapsed content</h5>
      <span class="text-muted">Toggleable via the navbar brand.</span>
    </div>
  </div>
  <nav class="navbar navbar-dark bg-dark">
    <button class="navbar-toggler" type="button" data-toggle="collapse" data-target="#navbarToggleExternalContent" aria-controls="navbarToggleExternalContent" aria-expanded="false" aria-label="Toggle navigation">
      <span class="navbar-toggler-icon"></span>
    </button>
  </nav>
</div>

I took a look at the commit history, and found one stating that it has been renamed to position-fixed.

Thank you

@mdo mdo added this to Inbox in v5 via automation Apr 2, 2020
@mdo mdo added this to To do in v4.5.0 via automation Apr 2, 2020
@mdo mdo removed the v5 label Apr 2, 2020
@mdo mdo removed this from Inbox in v5 Apr 2, 2020
@XhmikosR XhmikosR linked a pull request Apr 15, 2020 that will close this issue
@mdo mdo added the has-pr label Apr 30, 2020
@mdo mdo moved this from To do to Inbox in v4.5.0 Apr 30, 2020
@XhmikosR
Copy link
Member

Fixed in #30505

@XhmikosR XhmikosR moved this from Inbox to Shipped in v4.5.0 Apr 30, 2020
@XhmikosR XhmikosR removed this from Shipped in v4.5.0 Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants