Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spinner-grow animation #30504

Merged
merged 4 commits into from Apr 8, 2020
Merged

Fix spinner-grow animation #30504

merged 4 commits into from Apr 8, 2020

Conversation

mdo
Copy link
Member

@mdo mdo commented Apr 2, 2020

Safari seems to be interpreting the old keyframes animation as incomplete. Adding transform to the second frame seems to resolve the issue.

Fixes #30493.

Safari seems to be interpreting the old keyframes animation as incomplete. Adding `transform` to the second frame seems to resolve the issue.
@mdo mdo requested a review from a team as a code owner April 2, 2020 22:11
@mdo mdo added this to Inbox in v5 via automation Apr 2, 2020
@mdo mdo added this to Inbox in v4.5.0 via automation Apr 2, 2020
scss/_spinners.scss Outdated Show resolved Hide resolved
@MartijnCuppens MartijnCuppens requested a review from ysds April 5, 2020 18:11
@XhmikosR
Copy link
Member

XhmikosR commented Apr 7, 2020

Ping @mdo about @MartijnCuppens's comment above 🙂

XhmikosR and others added 2 commits April 8, 2020 07:43
Copy link
Member

@ysds ysds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked transition: none works fine.

v5 automation moved this from Inbox to Approved Apr 8, 2020
@XhmikosR XhmikosR merged commit 64050f4 into master Apr 8, 2020
v5 automation moved this from Approved to Shipped Apr 8, 2020
@XhmikosR XhmikosR deleted the spinner-grow-animation branch April 8, 2020 17:58
XhmikosR pushed a commit that referenced this pull request Apr 8, 2020
* Fix spinner-grow animation

Safari seems to be interpreting the old keyframes animation as incomplete. Adding `transform` to the second frame seems to resolve the issue.

Co-Authored-By: Martijn Cuppens <martijn.cuppens@gmail.com>
@XhmikosR XhmikosR moved this from Inbox to Cherry-picked in v4.5.0 Apr 8, 2020
XhmikosR pushed a commit that referenced this pull request Apr 9, 2020
* Fix spinner-grow animation

Safari seems to be interpreting the old keyframes animation as incomplete. Adding `transform` to the second frame seems to resolve the issue.

Co-Authored-By: Martijn Cuppens <martijn.cuppens@gmail.com>
XhmikosR pushed a commit that referenced this pull request Apr 10, 2020
* Fix spinner-grow animation

Safari seems to be interpreting the old keyframes animation as incomplete. Adding `transform` to the second frame seems to resolve the issue.

Co-Authored-By: Martijn Cuppens <martijn.cuppens@gmail.com>
XhmikosR pushed a commit that referenced this pull request Apr 13, 2020
* Fix spinner-grow animation

Safari seems to be interpreting the old keyframes animation as incomplete. Adding `transform` to the second frame seems to resolve the issue.

Co-Authored-By: Martijn Cuppens <martijn.cuppens@gmail.com>
@XhmikosR XhmikosR moved this from Cherry-picked to Shipped in v4.5.0 Apr 13, 2020
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
* Fix spinner-grow animation

Safari seems to be interpreting the old keyframes animation as incomplete. Adding `transform` to the second frame seems to resolve the issue.

Co-Authored-By: Martijn Cuppens <martijn.cuppens@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.5.0
  
Shipped
v5
  
Shipped
Development

Successfully merging this pull request may close these issues.

Growing spinners show as blank in Safari
4 participants