Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event propagation from inactive and disabled dropdowns (#30510) #30511

Merged

Conversation

luktom
Copy link

@luktom luktom commented Apr 3, 2020

Please see #30510 for details. Two new unit tests added. "npm run test" was finished without errors.

@luktom luktom requested a review from a team as a code owner April 3, 2020 16:34
@XhmikosR
Copy link
Member

XhmikosR commented Apr 3, 2020 via email

@XhmikosR XhmikosR added the v4 label Apr 4, 2020
@Johann-S
Copy link
Member

Johann-S commented Apr 7, 2020

Would you mind @luktom to backport that in our v5 ? By doing another PR which target our master branch

@luktom
Copy link
Author

luktom commented Apr 7, 2020

@XhmikosR sorry, I thought you already moved to master with v5 development and my bug is reproducible on v4. I know that "Contribution" page says that you should make your PRs to master but as stable version is v4 and v5 is in master I was confused.

@Johann-S sure, I will do it.

@XhmikosR
Copy link
Member

XhmikosR commented Apr 7, 2020

I'm gonna merge this for now and add it to the v5 project until we have a PR against master too, thanks @luktom!

@XhmikosR XhmikosR merged commit 8cc9def into twbs:v4-dev Apr 7, 2020
@XhmikosR XhmikosR added this to Inbox in v4.5.0 via automation Apr 7, 2020
@XhmikosR XhmikosR removed the v5 label Apr 7, 2020
@XhmikosR XhmikosR added this to Inbox in v5 via automation Apr 7, 2020
@XhmikosR XhmikosR moved this from Inbox to Shipped in v4.5.0 Apr 7, 2020
@XhmikosR XhmikosR moved this from Inbox to Tracking in v5 Apr 7, 2020
@luktom
Copy link
Author

luktom commented Apr 7, 2020

I'm gonna merge this for now and add it to the v5 project until we have a PR against master too, thanks @luktom!

@XhmikosR please find a PR for master here: #30529.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v4.5.0
  
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

4 participants