Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use box-shadow mixin for .btn #30512

Merged
merged 3 commits into from Apr 11, 2020
Merged

Use box-shadow mixin for .btn #30512

merged 3 commits into from Apr 11, 2020

Conversation

zalog
Copy link
Contributor

@zalog zalog commented Apr 4, 2020

This pr:

  • fixes css prop box-shadow when $btn-box-shadow: none
  • passes checking for vars in box-shadow mixin

@zalog zalog requested a review from a team as a code owner April 4, 2020 14:13
@zalog zalog changed the title Zalog btn box shadow btn box shadow fix Apr 4, 2020
@zalog zalog changed the title btn box shadow fix .btn box-shadow fix Apr 4, 2020
@MartijnCuppens MartijnCuppens requested a review from ysds April 5, 2020 17:37
@MartijnCuppens MartijnCuppens added this to Inbox in v4.5.0 via automation Apr 5, 2020
@MartijnCuppens MartijnCuppens added this to Inbox in v5.0.0-alpha2 via automation Apr 5, 2020
@zalog zalog force-pushed the zalog-btn-box-shadow branch 3 times, most recently from a194380 to 5e75e1f Compare April 7, 2020 06:18
@zalog
fix(css): checks for $btn-box-shadow
8ddfdbb 
Fixes `box-shadow` property being invalid when that var in `none`.
@zalog
perf(css): adds box-shadow where needed
b244872 
`box-shadow` mixin already checks for property `none`.
@zalog zalog changed the title .btn box-shadow fix Use box-shadow mixin for .btn Apr 11, 2020
@zalog
Copy link
Contributor Author

zalog commented Apr 11, 2020

Just made a rebase here.

cc:// #30480 and #30555

@MartijnCuppens MartijnCuppens moved this from Inbox to Needs manual backport in v4.5.0 Apr 11, 2020
v5.0.0-alpha2 automation moved this from Inbox to Approved Apr 11, 2020
@MartijnCuppens MartijnCuppens merged commit 8cb60bf into twbs:master Apr 11, 2020
v5.0.0-alpha2 automation moved this from Approved to Shipped Apr 11, 2020
@zalog zalog deleted the zalog-btn-box-shadow branch April 11, 2020 11:46
@MartijnCuppens MartijnCuppens moved this from Needs manual backport to Cherry-picked in v4.5.0 Apr 11, 2020
@XhmikosR XhmikosR added this to Inbox in v5 via automation Apr 11, 2020
@XhmikosR XhmikosR removed this from Shipped in v5.0.0-alpha2 Apr 11, 2020
@XhmikosR XhmikosR moved this from Inbox to Shipped in v5 Apr 11, 2020
XhmikosR pushed a commit that referenced this pull request Apr 11, 2020
@MartijnCuppens @XhmikosR
Backport #30512
77d722f 
Use `box-shadow` mixin for `.btn`
XhmikosR pushed a commit that referenced this pull request Apr 13, 2020
@MartijnCuppens @XhmikosR
Backport #30512
4d863ef 
Use `box-shadow` mixin for `.btn`
@XhmikosR XhmikosR moved this from Cherry-picked to Shipped in v4.5.0 Apr 13, 2020
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
@zalog @MartijnCuppens @olsza
Use box-shadow mixin for .btn (twbs#30512)
3041d5e 
Co-authored-by: Martijn Cuppens <martijn.cuppens@gmail.com>
@nelsonni nelsonni mentioned this pull request Jan 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartijnCuppens MartijnCuppens MartijnCuppens approved these changes

@ysds ysds Awaiting requested review from ysds

Assignees
No one assigned
Labels
backport-to-v4 css v5
Projects
No open projects
v4.5.0
  
Shipped
v5
  
Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zalog @MartijnCuppens