Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use box-shadow mixin for .form-select #30555

Merged
merged 1 commit into from Apr 11, 2020
Merged

Use box-shadow mixin for .form-select #30555

merged 1 commit into from Apr 11, 2020

Conversation

zalog
Copy link
Contributor

@zalog zalog commented Apr 11, 2020

This PR fixes css property box-shadow become invalid when $enable-shadows: true; and one of $form-select-box-shadow or $form-select-focus-box-shadow are null.

@zalog zalog requested a review from a team as a code owner April 11, 2020 08:23
@zalog zalog mentioned this pull request Apr 11, 2020
Merged
MartijnCuppens
MartijnCuppens approved these changes Apr 11, 2020
View reviewed changes
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartijnCuppens MartijnCuppens merged commit 939beea into twbs:master Apr 11, 2020
@MartijnCuppens MartijnCuppens added this to Inbox in v5 via automation Apr 11, 2020
@MartijnCuppens MartijnCuppens moved this from Inbox to Shipped in v5 Apr 11, 2020
@zalog zalog deleted the zalog-form-select-shadow branch April 11, 2020 11:29
@MartijnCuppens MartijnCuppens added this to Inbox in v4.5.0 via automation Apr 11, 2020
@MartijnCuppens MartijnCuppens moved this from Inbox to Needs manual backport in v4.5.0 Apr 11, 2020
@MartijnCuppens MartijnCuppens moved this from Needs manual backport to Cherry-picked in v4.5.0 Apr 11, 2020
XhmikosR pushed a commit that referenced this pull request Apr 11, 2020
@MartijnCuppens @XhmikosR
Backport #30555
35aa9c9 
Use `box-shadow` mixin for `.form-select`
XhmikosR pushed a commit that referenced this pull request Apr 13, 2020
@MartijnCuppens @XhmikosR
Backport #30555
abc17a4 
Use `box-shadow` mixin for `.form-select`
@XhmikosR XhmikosR moved this from Cherry-picked to Shipped in v4.5.0 Apr 13, 2020
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
@zalog @olsza
Use box-shadow mixin for .form-select (twbs#30555)
a8bfdae
@nelsonni nelsonni mentioned this pull request Jan 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartijnCuppens MartijnCuppens MartijnCuppens approved these changes

Assignees
No one assigned
Labels
backport-to-v4 css v4 v5
Projects
No open projects
v4.5.0
  
Shipped
v5
  
Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zalog @MartijnCuppens