Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5: Improve the responsiveness of our Dashboard example #30573

Merged
merged 2 commits into from Apr 15, 2020

Conversation

mdo
Copy link
Member

@mdo mdo commented Apr 13, 2020

Cleans up some column classes to ensure things line up across all viewports. Also fixes some broken padding on the .navbar-brand. Wondering if we backport the changes to this example?

Fixes #25552.

Preview: https://deploy-preview-30573--twbs-bootstrap.netlify.com/docs/4.3/examples/dashboard/

Cleans up some column classes to ensure things line up across all viewports. Also fixes some broken padding on the .navbar-brand.
@mdo mdo added this to Inbox in v5.0.0-alpha2 via automation Apr 13, 2020
@XhmikosR
Copy link
Member

We should backport it to v4-dev, yeah.

@XhmikosR XhmikosR added this to Inbox in v4.5.0 via automation Apr 14, 2020
@mdo mdo removed this from Inbox in v5.0.0-alpha2 Apr 14, 2020
@mdo mdo added this to Inbox in v5 via automation Apr 14, 2020
@mdo
Copy link
Member Author

mdo commented Apr 14, 2020

Feel free to merge whenever @XhmikosR so we can backport. I'm assuming some other changes have been made here in master to this example since it differs from v4.4's example with no responsive sidebar toggle.

v5 automation moved this from Inbox to Approved Apr 14, 2020
@XhmikosR XhmikosR merged commit fea6f69 into master Apr 15, 2020
v5 automation moved this from Approved to Shipped Apr 15, 2020
@XhmikosR XhmikosR deleted the v5-responsive-dashboard-improvements branch April 15, 2020 04:22
@XhmikosR XhmikosR moved this from Inbox to Cherry-picked in v4.5.0 Apr 15, 2020
XhmikosR added a commit that referenced this pull request Apr 15, 2020
Cleans up some column classes to ensure things line up across all viewports. Also fixes some broken padding on the .navbar-brand.

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
XhmikosR added a commit that referenced this pull request Apr 17, 2020
Cleans up some column classes to ensure things line up across all viewports. Also fixes some broken padding on the .navbar-brand.

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
XhmikosR added a commit that referenced this pull request Apr 18, 2020
Cleans up some column classes to ensure things line up across all viewports. Also fixes some broken padding on the .navbar-brand.

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
XhmikosR added a commit that referenced this pull request Apr 28, 2020
Cleans up some column classes to ensure things line up across all viewports. Also fixes some broken padding on the .navbar-brand.

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
@XhmikosR XhmikosR moved this from Cherry-picked to Shipped in v4.5.0 Apr 28, 2020
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Cleans up some column classes to ensure things line up across all viewports. Also fixes some broken padding on the .navbar-brand.

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.5.0
  
Shipped
v5
  
Shipped
Development

Successfully merging this pull request may close these issues.

Responsive sidebar in Dashboard example
3 participants