Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete appearance from button.close #30582

Merged
merged 1 commit into from Apr 14, 2020
Merged

Delete appearance from button.close #30582

merged 1 commit into from Apr 14, 2020
+0 −1

Conversation

k-utsumi
Copy link
Contributor

@k-utsumi k-utsumi commented Apr 14, 2020 •
edited

@k-utsumi k-utsumi requested a review from a team as a code owner April 14, 2020 13:30
@MartijnCuppens MartijnCuppens added this to Inbox in v5 via automation Apr 14, 2020
@MartijnCuppens MartijnCuppens added this to Inbox in v4.5.0 via automation Apr 14, 2020
v5 automation moved this from Inbox to Approved Apr 14, 2020
MartijnCuppens
MartijnCuppens approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need that indeed, .btns do not have an appearance either.

@MartijnCuppens MartijnCuppens changed the title 🔥 Delete appearance from button.close Delete appearance from button.close Apr 14, 2020
@MartijnCuppens MartijnCuppens merged commit 3a0fb1f into twbs:master Apr 14, 2020
v5 automation moved this from Approved to Shipped Apr 14, 2020
@k-utsumi k-utsumi deleted the patch-1 branch April 14, 2020 15:26
@XhmikosR XhmikosR moved this from Inbox to Cherry-picked in v4.5.0 Apr 15, 2020
XhmikosR pushed a commit that referenced this pull request Apr 15, 2020
@k-utsumi @XhmikosR
Delete appearance from button.close (#30582)
de4d9d4
XhmikosR pushed a commit that referenced this pull request Apr 17, 2020
@k-utsumi @XhmikosR
Delete appearance from button.close (#30582)
2a46382
XhmikosR pushed a commit that referenced this pull request Apr 18, 2020
@k-utsumi @XhmikosR
Delete appearance from button.close (#30582)
4ecbaec
XhmikosR pushed a commit that referenced this pull request Apr 28, 2020
@k-utsumi @XhmikosR
Delete appearance from button.close (#30582)
0321c63
@XhmikosR XhmikosR moved this from Cherry-picked to Shipped in v4.5.0 Apr 28, 2020
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
@k-utsumi @olsza
Delete appearance from button.close (twbs#30582)
f83c1d9
@nelsonni nelsonni mentioned this pull request Jan 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartijnCuppens MartijnCuppens MartijnCuppens approved these changes

Assignees
No one assigned
Labels
backport-to-v4 css v4 v5
Projects
No open projects
v4.5.0
  
Shipped
v5
  
Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@k-utsumi @MartijnCuppens