Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: checks for $grid-row-columns #30606

Merged
merged 1 commit into from Apr 16, 2020
Merged

feat: checks for $grid-row-columns #30606

merged 1 commit into from Apr 16, 2020

Conversation

zalog
Copy link
Contributor

@zalog zalog commented Apr 16, 2020

This PR let us set $grid-row-columns: 0; and remove all .row-cols-* > *.

@zalog zalog requested a review from a team as a code owner April 16, 2020 17:05
MartijnCuppens
MartijnCuppens approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sublime 🤘

@MartijnCuppens MartijnCuppens added this to Inbox in v5 via automation Apr 16, 2020
@MartijnCuppens MartijnCuppens added this to Inbox in v4.5.0 via automation Apr 16, 2020
@MartijnCuppens MartijnCuppens merged commit 6b5f055 into twbs:master Apr 16, 2020
v5 automation moved this from Inbox to Shipped Apr 16, 2020
@zalog zalog deleted the zalog-grid-row-columns-0 branch April 16, 2020 17:16
@zalog
Copy link
Contributor Author

zalog commented Apr 16, 2020

Tnks :D

@XhmikosR XhmikosR moved this from Inbox to Cherry-picked in v4.5.0 Apr 17, 2020
@XhmikosR XhmikosR moved this from Cherry-picked to Needs manual backport in v4.5.0 Apr 17, 2020
@XhmikosR
Copy link
Member

@MartijnCuppens this needs to be manually backported. I already have a v4-dev-xmr branch you can backport it.

@zalog
Copy link
Contributor Author

zalog commented Apr 17, 2020

You mean make the same for v4 right?
I can help with that.

@zalog zalog mentioned this pull request Apr 17, 2020
Merged
XhmikosR pushed a commit that referenced this pull request Apr 17, 2020
@zalog
Backport #30606 (#30612)
7f137b9 
checks for `$grid-row-columns`
@XhmikosR XhmikosR moved this from Needs manual backport to Cherry-picked in v4.5.0 Apr 17, 2020
XhmikosR pushed a commit that referenced this pull request Apr 18, 2020
@zalog @XhmikosR
Backport #30606 (#30612)
e13db00 
checks for `$grid-row-columns`
@zalog zalog mentioned this pull request Apr 18, 2020
Merged
XhmikosR pushed a commit that referenced this pull request Apr 21, 2020
@zalog @XhmikosR
Backport #30606 (#30612)
6fd3895 
checks for `$grid-row-columns`
XhmikosR pushed a commit that referenced this pull request Apr 28, 2020
@zalog @XhmikosR
Backport #30606 (#30612)
9d00970 
checks for `$grid-row-columns`
@XhmikosR XhmikosR moved this from Cherry-picked to Shipped in v4.5.0 Apr 28, 2020
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
@zalog @olsza
feat: checks for $grid-row-columns (twbs#30606)
2f0283b
@nelsonni nelsonni mentioned this pull request Jan 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartijnCuppens MartijnCuppens MartijnCuppens approved these changes

Assignees
No one assigned
Labels
backport-to-v4 css v4 v5
Projects
No open projects
v4.5.0
  
Shipped
v5
  
Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zalog @XhmikosR @MartijnCuppens