Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: checks for $grid-breakpoints map list #30609

Merged
merged 2 commits into from Apr 17, 2020
Merged

feat: checks for $grid-breakpoints map list #30609

merged 2 commits into from Apr 17, 2020

Conversation

zalog
Copy link
Contributor

@zalog zalog commented Apr 16, 2020 •
edited

This PR let us set a empty $grid-breakpoints: (); list, if for any reason we want to remove all breakpoints.

Fixes sass error in case $grid-breakpoints list is empty:

Error: argument `$list` of `nth($list, $n)` must not be empty

@zalog zalog requested a review from a team as a code owner April 16, 2020 21:03
@MartijnCuppens MartijnCuppens added this to Inbox in v5 via automation Apr 17, 2020
@MartijnCuppens MartijnCuppens added this to Inbox in v4.5.0 via automation Apr 17, 2020
MartijnCuppens
MartijnCuppens approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

v5 automation moved this from Inbox to Approved Apr 17, 2020
@MartijnCuppens MartijnCuppens merged commit a8883a3 into twbs:master Apr 17, 2020
v5 automation moved this from Approved to Shipped Apr 17, 2020
@zalog
Copy link
Contributor Author

zalog commented Apr 17, 2020

Tnks M, I can backport it :D

MartijnCuppens added a commit that referenced this pull request Apr 17, 2020
@zalog @MartijnCuppens
feat: checks for $grid-breakpoints map list (#30609)
80b7696 
Co-authored-by: Martijn Cuppens <martijn.cuppens@gmail.com>
@zalog zalog deleted the zalog-functions-assert branch April 17, 2020 17:20
@MartijnCuppens MartijnCuppens moved this from Inbox to Cherry-picked in v4.5.0 Apr 17, 2020
@zalog zalog mentioned this pull request Apr 17, 2020
Closed
XhmikosR pushed a commit that referenced this pull request Apr 18, 2020
@zalog @MartijnCuppens @XhmikosR
feat: checks for $grid-breakpoints map list (#30609)
738b6db 
Co-authored-by: Martijn Cuppens <martijn.cuppens@gmail.com>
@zalog zalog mentioned this pull request Apr 18, 2020
Merged
XhmikosR pushed a commit that referenced this pull request Apr 21, 2020
@zalog @MartijnCuppens @XhmikosR
feat: checks for $grid-breakpoints map list (#30609)
d1828bb 
Co-authored-by: Martijn Cuppens <martijn.cuppens@gmail.com>
XhmikosR pushed a commit that referenced this pull request Apr 28, 2020
@zalog @MartijnCuppens @XhmikosR
feat: checks for $grid-breakpoints map list (#30609)
4853c5b 
Co-authored-by: Martijn Cuppens <martijn.cuppens@gmail.com>
@XhmikosR XhmikosR moved this from Cherry-picked to Shipped in v4.5.0 Apr 28, 2020
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
@zalog @MartijnCuppens @olsza
feat: checks for $grid-breakpoints map list (twbs#30609)
ec979be 
Co-authored-by: Martijn Cuppens <martijn.cuppens@gmail.com>
@nelsonni nelsonni mentioned this pull request Jan 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartijnCuppens MartijnCuppens MartijnCuppens approved these changes

Assignees
No one assigned
Labels
backport-to-v4 css v4 v5
Projects
No open projects
v4.5.0
  
Shipped
v5
  
Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zalog @MartijnCuppens