Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent list group style leaks #30660

Merged
merged 1 commit into from Apr 28, 2020
Merged

Conversation

MartijnCuppens
Copy link
Member

@MartijnCuppens MartijnCuppens commented Apr 28, 2020

Fixes #30657

Also prevents style leaks from nested horizontal list groups.

https://codepen.io/MartijnCuppens/pen/VwvWWJm

@MartijnCuppens MartijnCuppens requested a review from a team as a code owner April 28, 2020 07:17
@ffoodd ffoodd added this to Approved in v5 via automation Apr 28, 2020
@ffoodd
Copy link
Member

ffoodd commented Apr 28, 2020

LGTM :)

@MartijnCuppens MartijnCuppens merged commit ea34cc4 into master Apr 28, 2020
v5 automation moved this from Approved to Shipped Apr 28, 2020
@MartijnCuppens MartijnCuppens deleted the master-mc-list-group-border-fix branch April 28, 2020 07:24
MartijnCuppens added a commit that referenced this pull request Apr 28, 2020
@MartijnCuppens MartijnCuppens added this to Cherry-picked in v4.5.0 Apr 28, 2020
XhmikosR pushed a commit that referenced this pull request Apr 28, 2020
MartijnCuppens added a commit that referenced this pull request Apr 28, 2020
XhmikosR pushed a commit that referenced this pull request Apr 28, 2020
@XhmikosR XhmikosR moved this from Cherry-picked to Shipped in v4.5.0 Apr 28, 2020
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.5.0
  
Shipped
v5
  
Shipped
Development

Successfully merging this pull request may close these issues.

.list-group-flush doesn't allow nested "normal" .list-groups with borders
2 participants