Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add role="dialog" in the modal via script #30773

Closed
rohit2sharma95 opened this issue May 11, 2020 · 0 comments · Fixed by #30936
Closed

Add role="dialog" in the modal via script #30773

rohit2sharma95 opened this issue May 11, 2020 · 0 comments · Fixed by #30936

Comments

@rohit2sharma95
Copy link
Collaborator

rohit2sharma95 commented May 11, 2020 •
edited

As commented by @patrickhlauke in #30755

We could even consider injecting the role="dialog" via scripting (the same way aria-modal="true" is being injected).

role="dialog" should be removed from the HTML markup and should be added in the .modal via script.
rohit2sharma95 added a commit to rohit2sharma95/bootstrap that referenced this issue May 31, 2020
@rohit2sharma95
Add role="dialog" in the modal via script (Closes twbs#30773)
aa395eb 
- Update documentation
- Update unit tests
@rohit2sharma95 rohit2sharma95 mentioned this issue May 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add role="dialog" in modals via JavaScript rohit2sharma95/bootstrap
1 participant
@rohit2sharma95