Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.nav-item is not required on .nav-link inside .navbar-nav #30880

Closed
rohit2sharma95 opened this issue May 22, 2020 · 3 comments
Closed

.nav-item is not required on .nav-link inside .navbar-nav #30880

rohit2sharma95 opened this issue May 22, 2020 · 3 comments
Labels
docs v4 v5

Comments

@rohit2sharma95
Copy link
Collaborator

When list-based approach is not used for the navbar, class .nav-item is not required on .nav-link inside .navbar-nav. Link for the docs.

See this comment in #28423
@XhmikosR
Copy link
Member

Not sure what you mean by this issue? Is it a documentation issue?

@rohit2sharma95
Copy link
Collaborator Author

Yup @XhmikosR. I mean docs should be updated and .nav-item class should be removed from .nav-link. (Only when the list-based approach is not used for the navbar)

@XhmikosR XhmikosR added the docs label May 26, 2020
@psjishnu psjishnu mentioned this issue May 27, 2020
Closed
@mdo mdo added this to Inbox in v5 via automation May 30, 2020
@mdo mdo added this to Inbox in v4.5.1 via automation May 30, 2020
@rohit2sharma95 rohit2sharma95 mentioned this issue Jun 5, 2020
Merged
@XhmikosR
Copy link
Member

XhmikosR commented Jun 9, 2020

Fixed in #30973.

@XhmikosR XhmikosR closed this as completed Jun 9, 2020
v5 automation moved this from Inbox to Shipped Jun 9, 2020
@XhmikosR XhmikosR removed this from Shipped in v5 Jun 9, 2020
@XhmikosR XhmikosR removed this from Inbox in v4.5.1 Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs v4 v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed Navbar documentation
3 participants
@mdo @XhmikosR @rohit2sharma95