Prevent skip links from overlapping header #30897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this solution work for the supported browsers in v4-dev too? Because IE is supported in v4-dev. |
|
Yes it will, it'll simply work as it did previously: displaying links one by one, at the same place. IE11 and other unsupporting browsers will simply ignore the |
|
OK, cool, then I'll wait for the other to have a look and if this lands, I'm going to backport it to v4-dev. |
XhmikosR
force-pushed
the
master-fod-skiplinks-theming
branch
from
0d80974
to
b5ba395
Compare
|
@ffoodd can you backport this and the previous skip links PR if it applies to v4-dev? We have it in the v4-dev-next project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here it is, after #30073 discussions: I got back the kind of banner that appeared previously, only aligning skip-links to the left.
As a bonus (feel free to discuss it, of course), I enhanced progressively the whole thing by making all skip links appear together when
:focusis within the container.And to stay consistent with #30866 I used utilities, seems legit in that case.
Preview: https://deploy-preview-30897--twbs-bootstrap.netlify.app/
Fixes #30491