Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled checked states wrong background #30922

Merged
merged 2 commits into from Jun 15, 2020

Conversation

ffoodd
Copy link
Member

@ffoodd ffoodd commented May 29, 2020

Fixes #29809 for v4.

V5 doesn't need this since :disabled simply decreases opacity for disabled fields, whatever their background is.

@ffoodd ffoodd requested a review from a team as a code owner May 29, 2020 09:46
@ffoodd ffoodd force-pushed the v4-dev-fod-disabled-checked-custom-inputs branch from 6921d97 to bb37992 Compare May 29, 2020 09:47
@mdo mdo added this to Inbox in v4.5.1 via automation Jun 15, 2020
@XhmikosR XhmikosR merged commit 7b5e48d into v4-dev Jun 15, 2020
@XhmikosR XhmikosR deleted the v4-dev-fod-disabled-checked-custom-inputs branch June 15, 2020 05:41
@XhmikosR XhmikosR moved this from Inbox to Shipped in v4.5.1 Jun 15, 2020
@XhmikosR
Copy link
Member

XhmikosR commented Jun 21, 2020

@ffoodd it seems this results in duplicate background-color properties:

 .custom-checkbox .custom-control-input:disabled:checked ~ .custom-control-label::before {
   background-color: rgba(0, 123, 255, 0.5);
+  background-color: rgba(0, 123, 255, 0.5);
 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v4.5.1
  
Shipped
Development

Successfully merging this pull request may close these issues.

disabled custom checkbox with gradients is not grayed out in checked state
3 participants