Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit floating example for IE/Edge #30964

Closed
XhmikosR opened this issue Jun 4, 2020 · 2 comments · Fixed by #30965 or #30966
Closed

Revisit floating example for IE/Edge #30964

XhmikosR opened this issue Jun 4, 2020 · 2 comments · Fixed by #30965 or #30966

Comments

@XhmikosR
Copy link
Member

XhmikosR commented Jun 4, 2020

About the floating labels example, I'm a bit confused: there's an old patch for IE that seems to… break the example.

If I remove it, the example works fine in IE11 (tested on BrowserStack, W7 & W10).
However the Edge patch seems required. Both were introduced in #25919, but MDN compatibility table seems clear: IE10 & 11 did support their vendor version.

I'd be in favor of removing it (but should probably be another PR, souldn't it?).

Originally posted by @ffoodd in #30836 (comment)

@XhmikosR
Copy link
Member Author

XhmikosR commented Jun 4, 2020

I haven't checked master BTW.

@XhmikosR XhmikosR added this to Inbox in v4.5.1 via automation Jun 4, 2020
This was linked to pull requests Jun 4, 2020
@ffoodd
Copy link
Member

ffoodd commented Jun 4, 2020

I made 2 PRs:

@XhmikosR XhmikosR removed this from Inbox in v4.5.1 Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants