Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating labels improvements #30966

Merged
merged 2 commits into from Jun 24, 2020
Merged

Floating labels improvements #30966

merged 2 commits into from Jun 24, 2020

Conversation

ffoodd
Copy link
Member

@ffoodd ffoodd commented Jun 4, 2020

Next to #30965 — for v5 concerns.

  1. Edge fallback can be accessible by not making labels display: none and simply switching to flex reversed layout…
  2. Refactored things a bit since we have plenty of vendor prefixes in this file, whilst none of our supported browser require it.

Preview: https://deploy-preview-30966--twbs-bootstrap.netlify.app/docs/5.0/examples/floating-labels/

@ffoodd ffoodd requested a review from a team as a code owner June 4, 2020 09:31
@ffoodd ffoodd linked an issue Jun 4, 2020 that may be closed by this pull request
@XhmikosR XhmikosR added this to Inbox in v5 via automation Jun 4, 2020
@XhmikosR XhmikosR added this to Inbox in v4.5.1 via automation Jun 4, 2020
@XhmikosR XhmikosR added the v4 label Jun 4, 2020
@mdo mdo moved this from Inbox to Review in v5 Jun 15, 2020
mdo
mdo previously approved these changes Jun 16, 2020
v5 automation moved this from Review to Approved Jun 16, 2020
@mdo
Copy link
Member

mdo commented Jun 16, 2020

Testing this on Netlify in IE11 isn't super clear to me... that's likely because I'm looking at v5's code that doesn't support IE at all anymore, but the example doesn't work there anymore. Signed off on this earlier, but going to retract and punt to alpha 2 to confirm a few things first <3.

@mdo mdo dismissed their stale review June 16, 2020 02:12

unsure about netlify demo

@mdo mdo removed this from Approved in v5 Jun 16, 2020
@mdo mdo added this to Inbox in v5.0.0-alpha2 via automation Jun 16, 2020
@mdo mdo changed the base branch from master to main June 16, 2020 19:32
@XhmikosR
Copy link
Member

Could be because the branch was behind, have another try @mdo. Note that this PR is for Edge not IE since IE is not supported on v5.

v5.0.0-alpha2 automation moved this from Inbox to Review Jun 22, 2020
@ffoodd ffoodd force-pushed the master-fod-Edge-floating-labels branch from 160606f to d9c1ba1 Compare June 24, 2020 10:19
@ffoodd ffoodd requested a review from XhmikosR June 24, 2020 10:20
v5.0.0-alpha2 automation moved this from Review to Approved Jun 24, 2020
@XhmikosR XhmikosR merged commit 9c320df into main Jun 24, 2020
v5.0.0-alpha2 automation moved this from Approved to Shipped Jun 24, 2020
@XhmikosR XhmikosR deleted the master-fod-Edge-floating-labels branch June 24, 2020 11:11
@XhmikosR XhmikosR moved this from Inbox to Cherry picked/Manually backported in v4.5.1 Jun 24, 2020
XhmikosR pushed a commit that referenced this pull request Jun 24, 2020
* docs(example): floating-labels' better Edge fallback

* docs(example): refactor floating-labels' CSS
@XhmikosR XhmikosR moved this from Cherry picked/Manually backported to Shipped in v4.5.1 Jun 24, 2020
XhmikosR pushed a commit that referenced this pull request Jun 24, 2020
* docs(example): floating-labels' better Edge fallback

* docs(example): refactor floating-labels' CSS
@ffoodd ffoodd mentioned this pull request Sep 21, 2020
3 tasks
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
* docs(example): floating-labels' better Edge fallback

* docs(example): refactor floating-labels' CSS
mdo added a commit that referenced this pull request Oct 28, 2020
* v5: Promote floating labels example to component

- Adds new .form-floating
- Stubs out basics of a docs page
- Removes existing Example

* Update floating labels to support .form-select, make inputs and selects more consistent

- To do this, I made the .form-control and .form-select consistent in min-height vs height
- Removed some unused variables now
- Updated -color to be the -color because I don't know why this was any different before
- Update page to include some examples for layout, validation, and value
- Rewrite styles to not modify padding, but instead transform and opacity

* Streamline and bulletproof some things

- Apply some optimizations from code review
- Removed unecessary properties from the label
- Add some comments for what properties are required
- Move from fixed height for labels to height 100% so we can support textareas
- Improve docs a little bit, add ToC

* Move some values to variables, switch from scaling font-size to scale, update transforms

* Bring over changes from #30966 and add to them to tighten things up

* Delete the now unused example images

* Fix typo

* Allowlist the calc function

* Add transform-origin, update transform values

* Test out autofill fix

* Fix linter issue

* Mention it in the migration guide

* Bump bundlesize

* Add one more variable per review

* Shave .25rem off the height

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.5.1
  
Shipped
v5.0.0-alpha2
  
Shipped
Development

Successfully merging this pull request may close these issues.

Revisit floating example for IE/Edge
3 participants