Docs: fix old/broken example capture and typo #31070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't want to give impression that now it's ok to just sprinkle `role="button"` around. this at least makes the `span` keyboard-focusable, similar to at least the start of a custom control
XhmikosR
approved these changes
Jun 17, 2020
|
@patrickhlauke feel free to push the wording change to my |
does that mean cherry-picking and then pushing? or do i need to do anything more involved / making a manual change? happy to, just want to make sure i don't mess it up. |
|
oh...seems you may have already done it? |
|
Cherry picking doesn't always work so we do some stuff manually. I back
ported this already manually :)
…On Wed, Jun 17, 2020, 19:46 Patrick H. Lauke ***@***.***> wrote:
@patrickhlauke <https://github.com/patrickhlauke> feel free to push the
wording change to my v4-dev-xmr branch :)
does that mean cherry-picking and then pushing? or do i need to do
anything more involved / making a manual change? happy to, just want to
make sure i don't mess it up.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#31070 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACVLNPCME7X7M7LKTA5M6TRXDXODANCNFSM4OAQ7U4Q>
.
|
XhmikosR
added a commit
that referenced
this pull request
Jun 21, 2020
XhmikosR
added a commit
that referenced
this pull request
Jun 23, 2020
XhmikosR
added a commit
that referenced
this pull request
Jun 24, 2020
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
* Docs: fix old/broken example capture and typo * Make example less broken-looking don't want to give impression that now it's ok to just sprinkle `role="button"` around. this at least makes the `span` keyboard-focusable, similar to at least the start of a custom control Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.