Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: carousel, collapse, navs (tabs), popovers should use buttons rather than faked link buttons #31186

Closed
patrickhlauke opened this issue Jun 26, 2020 · 5 comments
Assignees

Comments

@patrickhlauke
Copy link
Member

patrickhlauke commented Jun 26, 2020

There's no good reason (other than ease of styling) for https://v5.getbootstrap.com/docs/5.0/components/carousel/, https://v5.getbootstrap.com/docs/5.0/components/collapse/, https://v5.getbootstrap.com/docs/5.0/components/navs/#javascript-behavior, https://v5.getbootstrap.com/docs/5.0/components/popovers/#dismiss-on-next-click to use <a href="#..." role="button">...</a> pseudo-buttons. While sure, BS can still support this, it'd be good to lead by example and use the correct <button> element for this (though I don't believe we have a neutral-enough button style out of the box to support carousel buttons...or at least, the current carousel controls need to be extended to neutralise the remaining button styles that creep in when swapping out the elements).

@patrickhlauke patrickhlauke changed the title Docs: carousel should use buttons rather than faked link buttons Docs: carousel, collapse, navs (tabs), popovers should use buttons rather than faked link buttons Jun 26, 2020
@divya661
Copy link

@XhmikosR I would like to work on this part of improving the documentation. I'll update the team regarding it as soon as possible. Can you assign this to me?

@XhmikosR
Copy link
Member

We don't assign issues to people and there's no need to ask for permission :) Just grab an issue, work on it and make a PR when ready.

@divya661
Copy link

divya661 commented Sep 26, 2020

@patrickhlauke @XhmikosR I'm currently working on it and got stuck in this https://v5.getbootstrap.com/docs/5.0/components/navs/#javascript-behavior Could you please provide any advice about replacing the anchor tag with the button on this part, if I have understood this issue properly?

@patrickhlauke
Copy link
Member Author

patrickhlauke commented Dec 27, 2020

Carousels will be addressed by #32627 and #32661
Dynamic tabs will be addressed by #32630
Collapse components now already use buttons in the examples, though it should be made clear that that's the preferred option #32632
Popovers can't currently be changed to buttons due to a bug/shortcoming of Safari and Firefox/macOS (as buttons there don't fire focus event when clicked with the mouse...urgh)

@patrickhlauke
Copy link
Member Author

Closing this as - apart from popovers using links, which is still necessary with our current approach due to Safari/macOS's odd duck behaviour, copied by Firefox/macOS - all major things are now sorted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants