Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove overflow: hidden from toasts #31381

Merged
merged 2 commits into from Jul 31, 2020
Merged

Remove overflow: hidden from toasts #31381

merged 2 commits into from Jul 31, 2020

Conversation

mdo
Copy link
Member

@mdo mdo commented Jul 31, 2020

Originally added overflow: hidden; as a lazy solution to rounding corners of the toast header. One more line of code would've done the trick properly. Fixes #31302.

Originally added overflow: hidden; as a lazy solution to rounding corners of the toast header. One more line of code would've done the trick properly. Fixes #31302
@mdo mdo requested a review from a team as a code owner July 31, 2020 04:46
@mdo mdo added this to Inbox in v5.0.0-alpha2 via automation Jul 31, 2020
@mdo mdo added this to Inbox in v4.5.1 via automation Jul 31, 2020
v5.0.0-alpha2 automation moved this from Inbox to Approved Jul 31, 2020
@MartijnCuppens MartijnCuppens merged commit 2bceb3e into main Jul 31, 2020
v5.0.0-alpha2 automation moved this from Approved to Shipped Jul 31, 2020
@MartijnCuppens MartijnCuppens deleted the toast-overflow branch July 31, 2020 11:29
@XhmikosR XhmikosR moved this from Inbox to Shipped in v4.5.1 Aug 3, 2020
@XhmikosR XhmikosR moved this from Shipped to Cherry picked/Manually backported in v4.5.1 Aug 3, 2020
@XhmikosR XhmikosR moved this from Cherry picked/Manually backported to Shipped in v4.5.1 Aug 3, 2020
XhmikosR pushed a commit that referenced this pull request Aug 3, 2020
XhmikosR added a commit that referenced this pull request Aug 3, 2020
Co-authored-by: Mark Otto <markd.otto@gmail.com>
dsynr added a commit to dsynr/bootstrap that referenced this pull request Aug 21, 2020
* Remove backdrop-filter from toasts

* BrowserStack: test on Edge 15

* Backport twbs#31135

* Move color utility callouts to start of page

Hierarchically/structurally, in the position they are currently at, the two callouts seem like they "belong" just to the "background color" section. Moving them to the start makes it clearer that those two callouts relate to everything in the page (both "Color" and "Background color" classes.

* Change heading level

otherwise the assistive technology callout looks like it's hierarchically under the "Dealing with specificity" heading

* Backport twbs#30326

Prevent overflowing static backdrop modal animation

TODO: backport the test too

* Backport twbs#30326 (Unit test)

* Update Babel config (twbs#31011)

* remove plugin-proposal-object-rest-spread
* add bugfixes
* `exclude: ['transform-typeof-symbol']` did nothing with our config

* Update devDependencies and gems

* Update dependencies, gems and regenerate package-lock.json (twbs#31261)

* @rollup/plugin-node-resolve 8.1.0
* popper.js 1.16.1
* qunit 2.10.1
* rollup 2.21.0

* Docs: forms accessibility cleanup (backport from v5) (twbs#31234)

* Expand advice for anchor-based controls

* Expand accessibility note in input group

* Correct statement about validation, fix server example

* Tweak label > accessible name

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Mark Otto <markd.otto@gmail.com>

* Turn off scroll anchoring for accordions (twbs#31347)

New default behavior for scroll anchoring (rolled out in Chrome 84?) leads to unsightly/odd accordion interactions - see twbs#31341
This rule suppresses this new behavior and reverts back to the old way.

See https://drafts.csswg.org/css-scroll-anchoring/

* Update to Ruby 2.7/Bundler 2.x. (twbs#31296)

* Clear timeout before showing the toast (twbs#31155)

* clear timeout before showing the toast

* Add unit test

* Remove the check for timeout

* Check for clearTimeout to have been called

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
# Conflicts:
#	js/tests/unit/toast.spec.js

* Add unit test for toast to check clearTimeout to have been called (twbs#31298)

* docs(skippy): prevent skip links from overlapping header

* Backport twbs#31344

Add toasts to the components requiring JavaScript

* Update devDependencies and gems

* @babel/cli                   ^7.10.4  →  ^7.11.0
* @babel/core                  ^7.10.4  →  ^7.11.0
* @rollup/plugin-babel          ^5.0.4  →   ^5.1.0
* @rollup/plugin-commonjs      ^13.0.0  →  ^14.0.0
* @rollup/plugin-node-resolve   ^8.1.0  →   ^8.4.0
* autoprefixer                  ^9.8.4  →   ^9.8.6
* eslint                        ^7.4.0  →   ^7.6.0
* karma                         ^5.1.0  →   ^5.1.1
* rollup                       ^2.21.0  →  ^2.23.0

* Remove overflow: hidden from toasts (twbs#31381) (twbs#31407)

Co-authored-by: Mark Otto <markd.otto@gmail.com>

* Backport twbs#31339 (twbs#31414)

* Backport twbs#31339

Add view on GitHub links for easier content editing from the docs

* Prepare v4.5.1. (twbs#31408)

* Remove flex: 1 0 100% from rows (twbs#31439) (twbs#31445)

Co-authored-by: XhmikosR <xhmikosr@gmail.com>

Co-authored-by: Mark Otto <markd.otto@gmail.com>

* Restore make-container-max-widths mixin

* Deprecate the `make-container-max-widths` mixin

* Remove undefined `$ignore-warning`

* Prepare v4.5.2. (twbs#31444)

Co-authored-by: Mark Otto <markd.otto@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: ysds <ysds.code@gmail.com>
Co-authored-by: Patrick H. Lauke <redux@splintered.co.uk>
Co-authored-by: Rohit Sharma <rohit2sharma95@gmail.com>
Co-authored-by: Gaël Poupard <gael.poupard@orange.com>
Co-authored-by: Martijn Cuppens <martijn.cuppens@gmail.com>
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.5.1
  
Shipped
v5.0.0-alpha2
  
Shipped
Development

Successfully merging this pull request may close these issues.

Dropdown not working inside toast
3 participants