Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-Select: all is not supported in IE or Edge Legacy #32092

Closed
coliff opened this issue Nov 9, 2020 · 10 comments
Closed

User-Select: all is not supported in IE or Edge Legacy #32092

coliff opened this issue Nov 9, 2020 · 10 comments

Comments

@coliff
Copy link
Contributor

coliff commented Nov 9, 2020

The Text Selection .user-select-all is not supported in IE or Edge Legacy.
REF: https://caniuse.com/mdn-css_properties_user-select_all

Maybe it could mention this as a note on on the v4 docs?
https://getbootstrap.com/docs/4.5/utilities/interactions/#text-selection

The compiled CSS actually includes:

.user-select-all {
  -ms-user-select: all !important;

but it doesn't do anything. Not really a big deal since it'd make almost no difference to the file-size after gzip compression - but Can that be excluded from the CSS? Or would this be an issue with Autoprefixer?

@XhmikosR
Copy link
Member

XhmikosR commented Nov 9, 2020

You should definitely make an issue upstream (autoprefixer) regarding the CSS since that's handled automatically for us.

@coliff
Copy link
Contributor Author

coliff commented Nov 9, 2020

cool will do that re: autoprefixer.

Should I open a PR for the v4 docs to mention that it's not supported? Something like:

Note: user-select-all is not supported on Internet Explorer or Edge Legacy.

@XhmikosR
Copy link
Member

XhmikosR commented Nov 9, 2020

I'd wait a bit until the issue is solved because it could be something documented wrong. Please link to the upstream issue and let us know of the outcome and then we can proceed with a docs callout if needed.

@coliff
Copy link
Contributor Author

coliff commented Nov 9, 2020

Sounds good. Opened an issue upstream: postcss/autoprefixer#1372

@coliff
Copy link
Contributor Author

coliff commented Nov 9, 2020

Neat! @ai has fixed it in Autoprefixer already and will release an update shortly!

@XhmikosR
Copy link
Member

XhmikosR commented Nov 9, 2020

@coliff feel free to send a PR adding a warning callout that this doesn't work on IE, otherwise we'll tackle it later. I still want to finish with the Hugo switch since that PR is touching almost all doc files.

@XhmikosR XhmikosR added this to To do in v4.6.0 Nov 9, 2020
@XhmikosR XhmikosR moved this from To do to Inbox in v4.6.0 Nov 9, 2020
@XhmikosR
Copy link
Member

Updated the deps in #32115 which takes case of one part of this issue. The callout is left; any PRs welcome.

@coliff
Copy link
Contributor Author

coliff commented Nov 10, 2020

cool - will open a PR for the docs within the hour.

@coliff
Copy link
Contributor Author

coliff commented Nov 10, 2020

What branch should the PR be made from - the v4-dev branch?

@XhmikosR
Copy link
Member

Fixed by #32151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.6.0
Awaiting triage
Development

Successfully merging a pull request may close this issue.

2 participants