Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add equal column mixin #32155

Merged
merged 3 commits into from Apr 6, 2021
Merged

Add equal column mixin #32155

merged 3 commits into from Apr 6, 2021

Conversation

cfxd
Copy link
Contributor

@cfxd cfxd commented Nov 14, 2020

Add equal column mixin so that we can do @include make-col-eq instead of having to extend the .col class or use it in markup.

Make the make-col mixin default to equal columns when not providing a column size.

@cfxd cfxd requested a review from a team as a code owner November 14, 2020 17:59
@mdo
Copy link
Member

mdo commented Dec 10, 2020

I think I can dig this. Put together a little Codepen: https://codepen.io/emdeoh/pen/JjRbXYr.

Since this only changes the mixin, I don't see any problems for us. Wondering if we need to update any docs?

@cfxd
Copy link
Contributor Author

cfxd commented Dec 10, 2020

Do you need me to make edits to that codepen? It looks like what I have in mind.

I can add a quick note for the docs about the default behavior.

@mdo
Copy link
Member

mdo commented Dec 10, 2020

No codepen edits needed. Just some docs updates I think to mention the behavior. Not sure where myself just yet, so feel free to suggest!

Make equal cols the default

Add documentation
@cfxd
Copy link
Contributor Author

cfxd commented Dec 16, 2020

Ok, thank you! Added a docs edit and rebased 👍🏻

@mdo mdo added this to Inbox in v5.0.0 via automation Apr 5, 2021
v5.0.0 automation moved this from Inbox to Approved Apr 5, 2021
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pretty nice idea 👌

@XhmikosR XhmikosR merged commit 0c56749 into twbs:main Apr 6, 2021
v5.0.0 automation moved this from Approved to Done Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants