Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(components/input-groups): add hint that custom file inputs require js to display the selected file name #32334

Closed
thetric opened this issue Dec 4, 2020 · 4 comments

Comments

@thetric
Copy link

thetric commented Dec 4, 2020

As a ng-bootstrap user (Angular + Bootstrap) I was confused that the custom file input component requires Bootstrap's JS to display the file name. ng-bootstrap does not require Bootstrap's JS. Bootstrap's documentation should clarify this.

Repro

Tested under Arch Linux with Firefox 84.0b4

@XhmikosR
Copy link
Member

XhmikosR commented Dec 4, 2020

It does not require Bootstrap's JS; it requires bs-custom-file-input and it's already documented: https://getbootstrap.com/docs/4.5/components/forms/#file-browser

@XhmikosR XhmikosR closed this as completed Dec 4, 2020
@patrickhlauke
Copy link
Member

It does not require Bootstrap's JS; it requires bs-custom-file-input and it's already documented: https://getbootstrap.com/docs/4.5/components/forms/#file-browser

not explicitly on https://getbootstrap.com/docs/4.5/components/input-group/#custom-file-input though, maybe worth adding some small note there? maybe cross-reference to https://getbootstrap.com/docs/4.5/components/forms/#file-browser ?

@XhmikosR
Copy link
Member

XhmikosR commented Dec 4, 2020

Feel free to add a note/callout, sure :)

@XhmikosR
Copy link
Member

#32457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants