Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple BackDrop from modal #32439

Merged
merged 5 commits into from Apr 14, 2021
Merged

Decouple BackDrop from modal #32439

merged 5 commits into from Apr 14, 2021

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Dec 11, 2020 •
edited

Based on a comment was post on offcanvas merge request, I did a first approach to decouple Backdrop from Modal, for further usage and to simplify Modal code.

It misses the extra tests and a class modification, but they can be done, if you like it

Preview: https://deploy-preview-32439--twbs-bootstrap.netlify.app/docs/5.0/components/modal/

TODO:

  • Revert the class name change since it's a breaking one
  • Revert any further breaking changes like variable names, new backdrop.scss file etc

@GeoSot GeoSot requested a review from a team as a code owner December 11, 2020 20:49
@GeoSot GeoSot force-pushed the baackdrop-as-separate-module branch from f18847d to 9e5bca6 Compare December 13, 2020 23:04
@GeoSot GeoSot force-pushed the baackdrop-as-separate-module branch 2 times, most recently from bfd37c9 to 3bdbe43 Compare January 12, 2021 21:41
@GeoSot GeoSot requested a review from a team as a code owner January 21, 2021 21:58
@GeoSot GeoSot force-pushed the baackdrop-as-separate-module branch from 459fd7a to 9ebb987 Compare January 21, 2021 21:59
@GeoSot GeoSot mentioned this pull request Feb 6, 2021
Merged
33 tasks
@GeoSot GeoSot force-pushed the baackdrop-as-separate-module branch from 83c261e to af28030 Compare February 6, 2021 18:21
@GeoSot GeoSot force-pushed the baackdrop-as-separate-module branch 5 times, most recently from 8f5868c to e7236ea Compare March 2, 2021 21:01
@GeoSot GeoSot force-pushed the baackdrop-as-separate-module branch 3 times, most recently from 3bd76c0 to 8c3479a Compare March 18, 2021 08:27
@GeoSot GeoSot force-pushed the baackdrop-as-separate-module branch from 8c3479a to 13ab497 Compare March 23, 2021 23:32
@GeoSot GeoSot force-pushed the baackdrop-as-separate-module branch 2 times, most recently from 50355b9 to cf96fc3 Compare April 3, 2021 23:54
@GeoSot GeoSot mentioned this pull request Apr 4, 2021
Merged
@GeoSot GeoSot force-pushed the baackdrop-as-separate-module branch 2 times, most recently from 6a38496 to 803d62c Compare April 6, 2021 22:14
rohit2sharma95
rohit2sharma95 reviewed Apr 7, 2021
View reviewed changes
js/src/modal.js Outdated Show resolved Hide resolved
js/src/util/backdrop.js Outdated Show resolved Hide resolved
js/src/util/backdrop.js Outdated Show resolved Hide resolved
js/src/util/backdrop.js Outdated Show resolved Hide resolved
js/src/util/backdrop.js Show resolved Hide resolved
@GeoSot GeoSot force-pushed the baackdrop-as-separate-module branch from a89a9cd to c503659 Compare April 7, 2021 10:04
alpadev
alpadev reviewed Apr 8, 2021
View reviewed changes
Copy link
Contributor

@alpadev alpadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor things 👍

js/src/modal.js Show resolved Hide resolved
js/src/util/index.js Outdated Show resolved Hide resolved
@GeoSot GeoSot force-pushed the baackdrop-as-separate-module branch from c503659 to 09eb84c Compare April 8, 2021 18:36
@GeoSot GeoSot added this to Inbox in v5.0.0 via automation Apr 9, 2021
@GeoSot GeoSot moved this from Inbox to Review in v5.0.0 Apr 9, 2021
@GeoSot GeoSot force-pushed the baackdrop-as-separate-module branch from 09eb84c to 05ca443 Compare April 11, 2021 18:54
v5.0.0 automation moved this from Review to Approved Apr 14, 2021
rohit2sharma95
rohit2sharma95 reviewed Apr 14, 2021
View reviewed changes
js/src/modal.js Outdated Show resolved Hide resolved
@GeoSot GeoSot force-pushed the baackdrop-as-separate-module branch from 522dfef to 2e0b0a7 Compare April 14, 2021 10:26
@mdo mdo merged commit 80085a1 into twbs:main Apr 14, 2021
v5.0.0 automation moved this from Approved to Done Apr 14, 2021
@GeoSot GeoSot deleted the baackdrop-as-separate-module branch April 14, 2021 20:53
@GeoSot GeoSot mentioned this pull request Jun 21, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit2sharma95 rohit2sharma95 rohit2sharma95 approved these changes

@alpadev alpadev alpadev approved these changes

Assignees
No one assigned
Labels
js no-backport-to-v4 v5
Projects
No open projects
v5.0.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GeoSot @alpadev @rohit2sharma95 @mdo