Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ".bs-rtl" and at-rule supports also at-rule supports not for "inset" logical property #32841

Closed
HNafiii opened this issue Jan 19, 2021 · 1 comment

Comments

@HNafiii
Copy link

HNafiii commented Jan 19, 2021

Hi Bootstrap
Thank you for Bootstrap v5beta1 release
For your request to a bootstrap.css, a CSS Logical Properties: inset shorthand property and "bs-rtl" class into bootstrap.css. My browser has supports inset-[block|inline]-[start|end] properties. Add at-rule supports for "inset" and non-"inset". For non-"inset" supported, add ".bs-rtl <>" and ":not(.bs-rtl) <>" for selector, and also left, right, top, and bottom for properties.

PS:

  • Remove comments syntax RTLCSS on non-rtl css file.
  • Remove any rtl css file.

Thanks.

@HNafiii HNafiii changed the title Add ".bs-rtl" and at-rule supports also at-rule supports not for inset Add ".bs-rtl" and at-rule supports also at-rule supports not for "inset" Jan 19, 2021
@HNafiii HNafiii changed the title Add ".bs-rtl" and at-rule supports also at-rule supports not for "inset" Add ".bs-rtl" and at-rule supports also at-rule supports not for "inset" logical property Jan 19, 2021
@ffoodd
Copy link
Member

ffoodd commented Jan 19, 2021

We thought about logical properties to implement RTL (see #30918) however it does not cover reliably all of our use cases and browser support for now.

And regarding your .bs-rtl suggestion, we also evoked that and concluded it would be a nightmare to maintain and work with. It had also been requested again (e.g. in # #32666) and we won't implement this— however I documented a pretty simple way to make this in a custom build.

So I'm closing this as duplicate.

@ffoodd ffoodd closed this as completed Jan 19, 2021
@ffoodd ffoodd added duplicate and removed feature labels Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants