New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text placement is not in the correct place in the example checkout-rtl #33170
Comments
Should it be addressed in the markup, as you suggest? It was moved on purpose to stay consistent with the reading direction (left being the end). Was this wrong? Won't moving the I'm opening #33179 to tackle this. Moreover you mentioned several issues, what are the others? |
My bad, in fact it's already covered in #33097 by @aqeelat → see L100 in checkout-rtl example. So that kind of answers my first question. :) Feel free to comment back for any other issue that wouldn't have been caught yet— and thanks for reporting! |
In this example RTL improvement for checkout, the gray text is in the right place and is true. The second point concerns the numerals in the examples, in the European form. Can be converted into Eastern Arabic numerals? |
Hi @Mrahmani71, I agree with your premise. Making sure the styles support these number formats should be a goal. Even though I personally tend to not use them, many other people do. So, I'll update the examples to include Hindu numerals. https://www.wikiwand.com/en/Hindu%E2%80%93Arabic_numeral_system |
I was observing the example of checkout-rtl, in which I saw many errors. If you look at the following images, you notice that the gray text positions in the "rtl" mode is not true, and the gray text is before the black text.
The text was updated successfully, but these errors were encountered: