Simplify Modal Config #33249
Merged
Simplify Modal Config #33249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohit2sharma95
approved these changes
Mar 5, 2021
js/src/modal.js
Outdated
|
|
||
| data = new Modal(target, config) | ||
| } | ||
| const data = Data.get(target, DATA_KEY) || new Modal(target, Manipulator.getDataAttributes(this)) |
There was a problem hiding this comment.
It is not mentioned anywhere in the docs that the data API reads the configuration from the data attributes of the toggle button also 🤯
There was a problem hiding this comment.
It's not either tested. I am in favor to omit it. If you agree so. To my eyes it's not a valid behavior
There was a problem hiding this comment.
It should be omitted IMO if it is not a breaking change 🤔
XhmikosR
reviewed
Mar 9, 2021
GeoSot
force-pushed
the
simplify-modal-config
branch
from
1468786
to
fd77b4f
Compare
XhmikosR
force-pushed
the
simplify-modal-config
branch
2 times, most recently
from
65144da
to
a625763
Compare
GeoSot
force-pushed
the
simplify-modal-config
branch
from
a625763
to
4415d54
Compare
GeoSot
force-pushed
the
simplify-modal-config
branch
from
4415d54
to
3c31e40
Compare
GeoSot
force-pushed
the
simplify-modal-config
branch
from
3c31e40
to
0bc4695
Compare
GeoSot
force-pushed
the
simplify-modal-config
branch
from
0bc4695
to
0801f13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.