Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make accordion icon rotation more natural #33292

Merged
merged 1 commit into from Apr 14, 2021
Merged

Make accordion icon rotation more natural #33292

merged 1 commit into from Apr 14, 2021

Conversation

inwardmovement
Copy link
Contributor

@inwardmovement inwardmovement commented Mar 7, 2021

@inwardmovement inwardmovement requested a review from a team as a code owner March 7, 2021 09:56
@mdo
Copy link
Member

mdo commented Apr 5, 2021

Hmm, I’ve come back to this a couple times and I’m not sure one way or another. Any references for what makes this more natural versus what’s there currently?

@inwardmovement
Copy link
Contributor Author

This feels more natural to me as it's a clockwise rotation, but I guess in the end it's pretty subjective indeed.

In Microsoft or Google UIs I found both rotations are used (but I'm not sure they are designed like this on purpose, maybe it's a detail they don't care much about).

I feel generally "clockwise" is more intuitive as we see it everyday on clocks/watches.
Clockwise ≈ forward/develop, counter-clockwise ≈ backward/collapse ?

@alecpl
Copy link
Contributor

alecpl commented Apr 8, 2021

It could use rotateX(180deg) transition, so there's no discussion about the rotation direction anymore ;)

@mdo mdo added this to Inbox in v5.0.0 via automation Apr 14, 2021
@mdo
Copy link
Member

mdo commented Apr 14, 2021

I'm fine merging this—I agree going with clockwise makes sense.

@mdo mdo merged commit f61a021 into twbs:main Apr 14, 2021
v5.0.0 automation moved this from Inbox to Done Apr 14, 2021
@inwardmovement inwardmovement deleted the patch-1 branch April 15, 2021 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v5.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants