Dropdown — Add option to make the dropdown menu clickable #33389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd love for this and the base PR to be a part of Beta 3 if we can manage it. Offering more control over the dropdown clicks here will be a huge win for usage and general UX. |
|
Do we need to do anything for v4? #26189 |
|
It can be backported to V4. |
rohit2sharma95
force-pushed
the
rohit/clickable-dropdown-menu
branch
2 times, most recently
from
d5c2ded
to
5af22d5
Compare
rohit2sharma95
force-pushed
the
rohit/clickable-dropdown-menu
branch
from
5af22d5
to
8db578e
Compare
|
What's our next steps here? |
|
@mdo, Sorry for the delay, I will update it further. |
|
@rohit2sharma95 can you take care of this soon? Otherwise let's move it to 5.1.0. |
rohit2sharma95
force-pushed
the
rohit/clickable-dropdown-menu
branch
from
838e6be
to
8be74ed
Compare
rohit2sharma95
force-pushed
the
rohit/clickable-dropdown-menu
branch
from
8be74ed
to
ce84722
Compare
alpadev
approved these changes
Apr 19, 2021
GeoSot
approved these changes
Apr 19, 2021
|
@rohit2sharma95 I guess we could, if it's not too much trouble, just note that this technically seems like a new feature. So, technically it should land in a 4.7.0 version. Just make sure you add the needed labels and we'll see when time comes to release a new 4.x version. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32723
Adding one more option
autoCloseto configure the auto close behavior of the dropdown.Preview: https://deploy-preview-33389--twbs-bootstrap.netlify.app/docs/5.0/components/dropdowns/#auto-close-behavior
Ref: https://ng-bootstrap.github.io/#/components/dropdown/api#NgbDropdown