New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global variable to enable box-shadow for focused inputs/buttons (v5) #33413
Comments
You can set |
@korki43 Yes, but why do you need unnecessary properties? it's garbage |
Duplicate of #32412, #32032 and clarified in the docs in #32685. We set our focus styles using shadows, and since we couldn't ensure anyone disabling those shadows would set proper focus styles, we don't provide a way to change this. Focus styles are mandatory, using |
it's not 5.x and I vote to add additional variable
How can users not want any "outer glow" on focusing? Changing background and border color is enough for me.
I don't dispute that. |
The first one is v5 and the PR too. If you've read discussions you'd noticed adding such variable has been suggested already. Changing background and borders is not enough regarding accessibility, since you'd basically convey focus state with color only. So, since we aim to enforce accessibility, we don't provide an easy way to drop focus styles. |
I don't found comments about new behavior variable. I don't want change behavior of
I don't understand you |
Now we have
$enable-shadows
, but this var does not affectbox-shadow
s used for focus states. I vote to add additional variable$enable-shadows-on-focus
(or something like this) to togglebox-shadow
on focus/hover/active.Also, I vote to add additional validation like as
@if $enable-shadows-on-focus and $input-btn-focus-box-shadow != none
.The text was updated successfully, but these errors were encountered: