Remove element event listeners through base component #33429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoSot
force-pushed
the
gs-base-component-dispose-element-events
branch
from
952cf90
to
44df1fa
Compare
GeoSot
force-pushed
the
gs-base-component-dispose-element-events
branch
2 times, most recently
from
1fc3f48
to
c07d8b8
Compare
alpadev
reviewed
Apr 8, 2021
GeoSot
force-pushed
the
gs-base-component-dispose-element-events
branch
from
c07d8b8
to
1e77cc4
Compare
alpadev
approved these changes
Apr 8, 2021
XhmikosR
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some research, I found out that EventHandler saves all the custom events per element using namespace, and is capable to remove Handlers using only the element and its namespace (
DATA_KEY).So, probably is better to utilize the base-component to do some serious jobs
Preview: https://deploy-preview-33429--twbs-bootstrap.netlify.app/