Add missing things in hide method of dropdown
#33451
Merged
+44
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoSot
approved these changes
Mar 24, 2021
GeoSot
reviewed
Mar 24, 2021
|
@rohit2sharma95 can you check if this applies to v4-dev too? And also @GeoSot's last comment :) |
|
Yes @XhmikosR , it will be backported to V4. |
rohit2sharma95
force-pushed
the
rohit/dropdown-hide-method
branch
from
8d8c97e
to
31f508a
Compare
rohit2sharma95
changed the title
aria-expanded attribute in hide method of dropdownhide method of dropdown
GeoSot
approved these changes
Mar 24, 2021
GeoSot
reviewed
Mar 24, 2021
| [].concat(...document.body.children) | ||
| .forEach(elem => EventHandler.off(elem, 'mouseover', null, noop())) | ||
| } | ||
|
|
There was a problem hiding this comment.
I think, till next pr this is not valid. you call it in the hide function, it is not triggered by any event ;)
|
@rohit2sharma95 can you please backport this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
hidemethod, the value of thearia-expandedattribute should be updated to false (like it is being inclearMenusfor now).hidemethod should remove event listener on the touch-enabled device (That was added in show method)Preview: https://deploy-preview-33451--twbs-bootstrap.netlify.app/docs/5.0/components/dropdowns/